You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I propose we remove the duplicate context entries, keeping the one with more translations and changing the context value to default like the example in the docs. Is there a way to lock down weblate to prevent duplicates? I don't understand how the duplicates even happen. We have CI checking the english file for duplicates but nothing for the other files as I was told we're not supposed to touch them and that is all on weblate.
The text was updated successfully, but these errors were encountered:
cewert
added
the
code-cleanup
This refactors or improves the code in some way; makes the code more maintainable.
label
Nov 16, 2023
The weblate translation files besides US english (https://github.com/jellyfin/jellyfin-roku/tree/unstable/locale) contain main duplicate translation entries as well as duplicate "centext"s.
We are using
.ts
files to hold the translations - link to docs. The example in the docs shows onecontext
tag with a value ofdefault
. https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/de_DE/translations.ts has 2 (the 2nd context has a value of ""), https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/es_ES/translations.ts has 2, https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/pt_BR/translations.ts has 2 etc.A lot of the duplication comes from the duplicate context tags which makes sense but there are also duplicate entries within the same context. For example, https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/pt_BR/translations.ts contains the string
<source>Change Server</source>
27 timesI propose we remove the duplicate context entries, keeping the one with more translations and changing the context value to default like the example in the docs. Is there a way to lock down weblate to prevent duplicates? I don't understand how the duplicates even happen. We have CI checking the english file for duplicates but nothing for the other files as I was told we're not supposed to touch them and that is all on weblate.
The text was updated successfully, but these errors were encountered: