Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weblate translation files contain many duplicate entries #1508

Open
cewert opened this issue Nov 16, 2023 · 0 comments
Open

Weblate translation files contain many duplicate entries #1508

cewert opened this issue Nov 16, 2023 · 0 comments
Labels
code-cleanup This refactors or improves the code in some way; makes the code more maintainable.

Comments

@cewert
Copy link
Member

cewert commented Nov 16, 2023

The weblate translation files besides US english (https://github.com/jellyfin/jellyfin-roku/tree/unstable/locale) contain main duplicate translation entries as well as duplicate "centext"s.

We are using .ts files to hold the translations - link to docs. The example in the docs shows one context tag with a value of default. https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/de_DE/translations.ts has 2 (the 2nd context has a value of ""), https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/es_ES/translations.ts has 2, https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/pt_BR/translations.ts has 2 etc.

A lot of the duplication comes from the duplicate context tags which makes sense but there are also duplicate entries within the same context. For example, https://github.com/jellyfin/jellyfin-roku/blob/unstable/locale/pt_BR/translations.ts contains the string <source>Change Server</source> 27 times

I propose we remove the duplicate context entries, keeping the one with more translations and changing the context value to default like the example in the docs. Is there a way to lock down weblate to prevent duplicates? I don't understand how the duplicates even happen. We have CI checking the english file for duplicates but nothing for the other files as I was told we're not supposed to touch them and that is all on weblate.

@cewert cewert added the code-cleanup This refactors or improves the code in some way; makes the code more maintainable. label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-cleanup This refactors or improves the code in some way; makes the code more maintainable.
Projects
Development

No branches or pull requests

1 participant