-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic generation of PDF #102
Comments
@bjornamr wow, this is really cool!! How much control do you have over the typography? I wonder if we can use some custom CSS to style the output for the PDF a little more page friendly? |
Inserting action.yml file for reference: Action.yml I am a bit unsure of how much control we have and I am no expert at styling or CSS. I see that puppeteer is what is used behind one of the steps called SetiZ/web_to_pdf_action. It seems to be based of this repo: fifsky/html-to-pdf-action#1 Would you be able to take a look at the fifsky solution? Maybe it is possible to include some fonts and css to generate better PDF. |
I have an Idea @jglovier after looking into this a little. From what I understand, to be able to control the PDF, you would have to write special css / sass for printing. This would make it possible to have full control and give you the ability to control fonts, placement etc. |
Oh nice! Yeah I can def make a custom stylesheet for the print layout. Not sure when I'll have some free time to work on it, but it's on my radar now. 👍 |
Just wanted to add that I figured out a bug in the action, so I updated it in the fork. |
Awesome! Thanks for the update, and for your patience. 🙇 Still on my radar. |
It is going to be added to the upstream project? |
@jglovier If you could give me some pointers or just some help to start up, I am sure I can help doing some of it. |
fff |
Hi
So the basic Idea I have in my fork of your code is that every time I update my resume, the PDF I have linked on my fork is updated.
I have added two things to the fork to make that happen:
You can take a look at my example on https://bjornamr.github.io/resume-template/
Do you want me to do a new fork and include these changes into a pull request?
Maybe update the README.md to explain how to create an access token.
The text was updated successfully, but these errors were encountered: