Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
Able to merge.
These branches can be automatically merged.
15
contributors
Commits on Oct 8, 2021
Commits on Oct 11, 2021
Commits on Oct 13, 2021
Commits on Oct 14, 2021
Commits on Oct 16, 2021
-
fix: fix server attachment (socketio#4127)
The check excluded an HTTPS server from being properly attached. Related: socketio#4124
Commits on Oct 24, 2021
-
-
fix: fix race condition in dynamic namespaces (socketio#4137)
Using an async operation with `io.use()` could lead to the creation of several instances of a same namespace, each of them overriding the previous one. Example: ```js io.use(async (nsp, auth, next) => { await anOperationThatTakesSomeTime(); next(); }); ``` Related: socketio#4136
Commits on Nov 8, 2021
-
feat: add type information to
socket.data(socketio#4159)Usage: ```js interface SocketData { name: string; age: number; } const io = new Server<ClientToServerEvents, ServerToClientEvents, InterServerEvents, SocketData>(); io.on("connection", (socket) => { socket.data.name = "john"; socket.data.age = 42; }); ```
Commits on Nov 12, 2021
-
feat: add an implementation based on uWebSockets.js
Usage: ```js const { App } = require("uWebSockets.js"); const { Server } = require("socket.io"); const app = new App(); const server = new Server(); server.attachApp(app); app.listen(3000); ``` The Adapter prototype is updated so we can benefit from the publish functionality of uWebSockets.js, so this will apply to all adapters extending the default adapter. Reference: https://github.com/uNetworking/uWebSockets.js Related: - socketio#3601 - socketio/engine.io#578 -
fix: only set 'connected' to true after middleware execution
The Socket instance is only considered connected when the "connection" event is emitted, and not during the middleware(s) execution. ```js io.use((socket, next) => { console.log(socket.connected); // prints "false" next(); }); io.on("connection", (socket) => { console.log(socket.connected); // prints "true" }); ``` Related: socketio#4129
Commits on Nov 16, 2021
-
`srv.close()` only closes the underlying HTTP server, but this does not terminate the existing WebSocket connections. Reference: https://nodejs.org/api/http.html#serverclosecallback
-
Usage: ```js socket.timeout(5000).emit("my-event", (err) => { if (err) { // the client did not acknowledge the event in the given delay } }); ```
Commits on Nov 18, 2021
-
fix: prevent double ack when emitting with a timeout
The ack was not properly removed upon timeout, and could be called twice. Related: socketio@f0ed42f
Commits on Nov 24, 2021
-
docs: simplify nginx cluster example
- remove useless Dockerfile - clean format - migrate to @socket.io/redis-adapter
Commits on Nov 30, 2021
Commits on Dec 16, 2021
Commits on Dec 28, 2021
-
chore: add types to exports field to be compatible with nodenext modu…
…le resolution (socketio#4228) See [1] for detail, in `nodenext` module resolution it requires a `types` field in `exports` with full filename including extension. [1]: microsoft/TypeScript#46770 (comment)
Commits on Jan 4, 2022
-
fix(typings): pass
SocketDatatype to custom namespaces (socketio#4233) The `SocketData` type was only available on the main namespace. Related: socketio#4229 See also: socketio@fe8730c
Commits on Jan 5, 2022
-
-
refactor(typings): export Event type (socketio#4215)
So that it can be used by the end users: ```ts const myMiddleware = ([eventName, ...args]: Event, next: (err?: Error) => void) => { console.log(eventName); // inferred as string next(); } io.on("connection", (socket) => { socket.use(myMiddleware); }); ```
Commits on Jan 6, 2022
-
Updating to v2 fails in the CI on Node.js 12 & 14 with the following error: > npm ERR! Error while executing: > npm ERR! /usr/bin/git ls-remote -h -t ssh://git@github.com/uNetworking/uWebSockets.js.git > npm ERR! > npm ERR! Warning: Permanently added the RSA host key for IP address '140.82.113.3' to the list of known hosts. > npm ERR! git@github.com: Permission denied (publickey). > npm ERR! fatal: Could not read from remote repository. > npm ERR! > npm ERR! Please make sure you have the correct access rights > npm ERR! and the repository exists. > npm ERR! > npm ERR! exited with error code: 128 So we will revert the change for now.
Commits on Jan 10, 2022
Commits on Jan 25, 2022
-
fix(typings): ensure compatibility with TypeScript 3.x (socketio#4259)
Labeled tuple elements were added in TypeScript 4.0. Reference: https://www.typescriptlang.org/docs/handbook/release-notes/typescript-4-0.html#labeled-tuple-elements Related: socketio@44e20ba
Commits on Jan 12, 2023
-
docs(examples): update docker-compose.yml (socketio#4594)
Updated docker compose to be in line with current practices. Reference: https://docs.docker.com/compose/
There are no files selected for viewing