Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a JRE 8 CI test action #2026

Closed
jhy opened this issue Nov 1, 2023 · 1 comment · Fixed by #2027
Closed

Add a JRE 8 CI test action #2026

jhy opened this issue Nov 1, 2023 · 1 comment · Fixed by #2027
Assignees
@jhy
Labels
fixed
Milestone
1.17.1

Comments

@jhy
Copy link
Owner

jhy commented Nov 1, 2023

To implement JPMS module support(#2025), the minimum JDK version for building jsoup becomes JDK 9. However we still will run on JRE 8. We do have the Animal Sniffer plugin to validate JRE 8 compatibility, but it would be better if we also had a specific CI action to test.

So this task is to add an action that executes after the build action (which will need to change to save the built jar into cache) and then runs the tests on JDK 8.
jhy added a commit that referenced this issue Nov 1, 2023
@jhy
Min builder is JDK 9
32b1074 
#2026 tracks adding a test action (not compile) for JDK 8.
@jhy jhy mentioned this issue Nov 1, 2023
Merged
jhy added a commit that referenced this issue Nov 1, 2023
@jhy
Repackaged the library with native (vs automatic) JPMS module support (…
a8564c3 
…#2025)

Repackaged the library with native (vs automatic) JPMS module support

Fixes #1943
Fixes #1466

Min builder is JDK 9

#2026 tracks adding a test action (not compile) for JDK 8.
jhy added a commit that referenced this issue Nov 1, 2023
@jhy
Move the multi-release to a JDK9+ profile
c3ee18f 
Allows JDK8 to build, albeit without multi-release / modules. Allows the CI actions to test on Java 8.

Fixes #2026
@jhy jhy mentioned this issue Nov 1, 2023
Merged
@jhy jhy closed this as completed in #2027 Nov 1, 2023
jhy added a commit that referenced this issue Nov 1, 2023
@jhy
Move the multi-release to a JDK9+ profile (#2027)
f3c4ab5 
Allows JDK8 to build, albeit without multi-release / modules. Allows the CI actions to test on Java 8.

Fixes #2026
@jhy jhy self-assigned this Nov 1, 2023
@jhy jhy added this to the 1.17.1 milestone Nov 1, 2023
@jhy jhy added the fixed label Nov 1, 2023
@jhy
Copy link
Owner Author

jhy commented Nov 1, 2023

(Fixed - updated the POM to use a JDK9+ profile to compile module-info; saved fiddling with CI actions, and enables folks to build on Java 8 if actually required)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jhy jhy

Labels
fixed
Projects
None yet
Milestone
1.17.1
Development

Successfully merging a pull request may close this issue.

Move the multi-release to a JDK9+ profile jhy/jsoup
1 participant
@jhy