Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct support for echo #195

Open
gnodet opened this issue Jul 24, 2015 · 1 comment
Open

Correct support for echo #195

gnodet opened this issue Jul 24, 2015 · 1 comment
Milestone

Comments

@gnodet
Copy link
Member

gnodet commented Jul 24, 2015

The echo support is completely broken.
When the terminal has echo enabled, normal processing should occur.
When the terminal has echo disabled, nothing should be printed.

The ConsoleReader.clearEcho() is a big hack in case the terminal can not be put into raw mode. But this is the responsibility of the client.
The client is either UnixTerminal or WindowsTerminal in case of a real console, but could be the ssh client. In the case of a remote terminal from ssh, the echo flag will always be set, but it should not mean that clearEcho should be used.

Ideally, we should also check and support echoctl, echonl flags.

@gnodet
Copy link
Member Author

gnodet commented Jul 24, 2015

We should later deprecate Terminal.isEchoEnabled() in favour of a more generic getRawLocalFlags() returning the stty local flags of the terminal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant