diff --git a/README.md b/README.md index bca50ef..adbb526 100644 --- a/README.md +++ b/README.md @@ -15,16 +15,13 @@ Starts the application in development mode and opens [http://localhost:3000](htt ## Things I Would Like to Have Done with More Time or Foresight -* Spend more time to test viewports/browsers * Spend more time adding accessibility features, like announcing new search results and having a content jump so you don't need to filter through all of the nav links * Add a "reset" button to the input field to more easily clear search * Spend less time trying to use a `useReducer` in the [useFetchUniList.tsx](./src/apis/useFetchUniList.tsx) file and just use regular effect and state and such -* Use a background image for the hero image instead of a regular `img` tag, since it seems kind of ancillary to the overall content -* Thought about filtering the search results via CSS +* Thought about filtering the search results via CSS (won't scale with things like virtualization) * was going to set all the text in a card to a `data-attribute` and then on search, hide all cards, except for ones that match something like `[data-query*="${searchText}"]` where `searchText` is the university you're looking for * See about adding some memoization for the search reducer -* Do some text manipulation for the school URLs, since they don't always match the Figma (trailing slashes, https, all-caps, etc.) * Add some tests * Add better TypeScript types * Add more error handling -* Update the favicon +* Add better loading/error state for search page diff --git a/public/index.html b/public/index.html index 13fd7e6..1d96a4a 100644 --- a/public/index.html +++ b/public/index.html @@ -2,7 +2,7 @@
- +