Merge pull request scala#4473 from retronym/ticket/9285

lrytz · lrytz · commit f1d7423ed41f · 2015-05-04T10:53:45.000+02:00
SI-9285 Don't warn about non-sensible equals in synthetic methods
diff --git a/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala b/src/compiler/scala/tools/nsc/typechecker/RefChecks.scala
@@ -1122,7 +1122,7 @@ abstract class RefChecks extends InfoTransform with scala.reflect.internal.trans
     }
     /** Sensibility check examines flavors of equals. */
     def checkSensible(pos: Position, fn: Tree, args: List[Tree]) = fn match {
-      case Select(qual, name @ (nme.EQ | nme.NE | nme.eq | nme.ne)) if args.length == 1 && isObjectOrAnyComparisonMethod(fn.symbol) =>
+      case Select(qual, name @ (nme.EQ | nme.NE | nme.eq | nme.ne)) if args.length == 1 && isObjectOrAnyComparisonMethod(fn.symbol) && !currentOwner.isSynthetic =>
         checkSensibleEquals(pos, qual, name, fn.symbol, args.head)
       case _ =>
     }
diff --git a/test/files/pos/t9285.flags b/test/files/pos/t9285.flags
@@ -0,0 +1 @@
+-Xfatal-warnings
diff --git a/test/files/pos/t9285.scala b/test/files/pos/t9285.scala
@@ -0,0 +1 @@
+case class C(placeholder: Unit)

Original file line number	Diff line number	Diff line change
`@@ -1122,7 +1122,7 @@ abstract class RefChecks extends InfoTransform with scala.reflect.internal.trans`
`1122`	`1122`	`}`
`1123`	`1123`	`/** Sensibility check examines flavors of equals. */`
`1124`	`1124`	`def checkSensible(pos: Position, fn: Tree, args: List[Tree]) = fn match {`
`1125`		`- case Select(qual, name @ (nme.EQ \| nme.NE \| nme.eq \| nme.ne)) if args.length == 1 && isObjectOrAnyComparisonMethod(fn.symbol) =>`
	`1125`	`+ case Select(qual, name @ (nme.EQ \| nme.NE \| nme.eq \| nme.ne)) if args.length == 1 && isObjectOrAnyComparisonMethod(fn.symbol) && !currentOwner.isSynthetic =>`
`1126`	`1126`	`checkSensibleEquals(pos, qual, name, fn.symbol, args.head)`
`1127`	`1127`	`case _ =>`
`1128`	`1128`	`}`