Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flutter_native_splash:create changes the formatting of AndroidManifest.xml and Info.plist even if no changes were made #718

Open
vanyasem opened this issue Aug 5, 2024 · 2 comments

Comments

@vanyasem
Copy link

vanyasem commented Aug 5, 2024

Describe the bug

flutter_native_splash:create changes the formatting of AndroidManifest.xml and Info.plist even if no changes were made

Configuration

flutter_native_splash:
  color: "#696969"
  android_screen_orientation: portrait
  image: assets_splash/splash.png
  android_gravity: center|bottom|clip_horizontal|clip_vertical
  ios_content_mode: scaleAspectFill
  web: false
  android_12:
    color: "#696969"

To Reproduce
Steps to reproduce the behavior, using the example app:

  1. Apply the splash screen by running flutter_native_splash:create
  2. Make formatting changes to AndroidManifest.xml/Info.plist
  3. Rerun flutter_native_splash:create
  4. Observe the fact that AndroidManifest.xml/Info.plist's formatting was changed, albeit no changes were made

Screenshots
Screenshot 2024-08-05 at 12 05 22

Additional context
I'd suggest adding a flag that would instruct flutter_native_splash to not make any changes to AndroidManifest.xml/Info.plist, and only replace the images themselves for cases where only the image needs replacement

@jonbhanson
Copy link
Owner

Sorry, I will not have time to make this update. Feel free to submit a pull request to address this if you would like.

@vanyasem
Copy link
Author

would you mind keeping the issue open and not marking is as completed? @jonbhanson

@jonbhanson jonbhanson reopened this Aug 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants