Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid lines #31

Closed
jonocarroll opened this issue Dec 6, 2019 · 8 comments
Closed

Grid lines #31

jonocarroll opened this issue Dec 6, 2019 · 8 comments

Comments

@jonocarroll
Copy link
Owner

Removing minor axis lines!

-- https://twitter.com/foundinblank/status/1202246795889455104?s=20

@foundinblank

@foundinblank
Copy link

Could be something like easy_remove_gridlines(minor = TRUE, major = TRUE)

@jonocarroll
Copy link
Owner Author

Which makes more sense to you?

easy_remove_x_gridlines(minor = TRUE, major = TRUE)

or

easy_remove_gridlines(minor_x = TRUE, major_x = TRUE)

or

easy_remove_x_minor_gridlines()

@foundinblank
Copy link

foundinblank commented Dec 8, 2019 via email

@thomas-neitmann
Copy link
Contributor

My suggestion would be to have these three functions:

  • easy_remove_x_gridlines(major = TRUE, minor = TRUE)
  • easy_remove_y_gridlines(major = TRUE, minor = TRUE)
  • easy_remove_xy_gridlines(major = TRUE, minor = TRUE) or alternatively easy_remove_all_gridlines(major = TRUE, minor = TRUE)

@jonocarroll
Copy link
Owner Author

Sounds good - I'm fine with having lots of functions/aliases so both xy and all are fine by me.

@thomas-neitmann
Copy link
Contributor

Awesome! You'll get another pull request soon 😉

@jonocarroll
Copy link
Owner Author

Completed via #45

@foundinblank
Copy link

This is awesome :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

3 participants