Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in Cassiopeia when using an anchor link #44636

Closed
1405djarnis opened this issue Dec 18, 2024 · 8 comments
Closed

Error in Cassiopeia when using an anchor link #44636

1405djarnis opened this issue Dec 18, 2024 · 8 comments

Comments

@1405djarnis
Copy link

Steps to reproduce the issue

If i chooses Sticky Header in Cassiopeia Templates: Edit Style

Cassiopeia do not take into account that there are a Sticky Header when using an anchor link and the text will be covered by the Header.

When clicking on an anchor link, the scroll does not stop in the right place and enters the Header, hiding part of the content. To solve this problem, CSS should be used.

Expected result

Actual result

System information (as much as possible)

Additional comments

@fgsw
Copy link

fgsw commented Dec 19, 2024

To solve this problem, CSS should be used.

Can you do a Pull request as you know the solution?

Comment: I didn't try to reproduce this issue as System information was ignored by @1405djarnis.

hans2103 added a commit to hans2103/joomla-cms that referenced this issue Jan 2, 2025
@hans2103
Copy link
Contributor

hans2103 commented Jan 2, 2025

PR #44679

@alikon
Copy link
Contributor

alikon commented Jan 2, 2025

clsing as we have a pr #44679

@alikon alikon closed this as completed Jan 2, 2025
@hans2103
Copy link
Contributor

hans2103 commented Jan 2, 2025

@1405djarnis please test #44679 to see if it solves your issue with default Cassiopeia

hans2103 added a commit to hans2103/joomla-cms that referenced this issue Jan 7, 2025
hans2103 added a commit to hans2103/joomla-cms that referenced this issue Jan 9, 2025
@1405djarnis
Copy link
Author

[hans2103]

Who to?

@hans2103
Copy link
Contributor

hans2103 commented Jan 10, 2025

[hans2103]

Who to?

what do you mean with "Who to?"

besides that... the PR has status "RTC", meaning Ready To Commit.
Already had enough successfull testers. At this moment no further testers needed.

@1405djarnis
Copy link
Author

Hi Hans2103

You wrote: Merge What do you mean by that? I don't understand, how can I Merge.

@hans2103
Copy link
Contributor

@1405djarnis I can't find where I've written "Merge"

#44636 (comment)

@1405djarnis please test #44679 to see if it solves your issue with default Cassiopeia

Merge is a term used in git version control which indicates that changes from one branche are pulled into another.
Because you do not seem to know the term merge I assume that you are a beginner with this term.
Please invest 36minutes watching the following YouTube video explaining git and github.com
https://www.youtube.com/watch?v=CvUiKWv2-C0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants