Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and install when updating instead of replacing files #601

Closed
jorgebucaran opened this issue Nov 9, 2020 · 0 comments
Closed

Remove and install when updating instead of replacing files #601

jorgebucaran opened this issue Nov 9, 2020 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@jorgebucaran
Copy link
Owner

Updating a plugin should fetch its latest version, and if that's successful, remove the old and install the new version, instead of trying to overwrite files.

Let's say we install some my/foobar which adds a foobar.fish and _foobar_bazinga.fish to our functions/. If we fisher update my/foobar when a new version of foobar is published that no longer has a _foobar_bazinga.fish, Fisher won't be able to remove _foobar_bazinga.fish, since the file won't be in the source directory.

This problem exists for both remote and local plugins, but it's even worse for local plugins because we use symlinks for them.

@jorgebucaran jorgebucaran added the bug Something isn't working label Nov 9, 2020
@jorgebucaran jorgebucaran added this to the 4.1.0 milestone Nov 9, 2020
jorgebucaran added a commit that referenced this issue Nov 9, 2020
- Remove and install when updating instead of replacing files (#601)
- Updating shouldn't remove plugin if the host is unvailable (#602)
- Can't reliably update local plugins because of symlinks (#603)
- Filter duplicates in argv and fish_plugins (#604)
- Add support to install plugins from branch names with slashes (#588)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant