Fix empty selector

josh · Apr 20, 2012 · 85a824e · 85a824e
1 parent ccc7e31
commit 85a824e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/css-explain.js b/css-explain.js
@@ -75,7 +75,9 @@
   // Returns 'id', 'class', 'tag', or 'universal'.
   function detectCategory(parts) {
     var last = parts[parts.length-1];
-    if (last.match(match.ID)) {
+    if (!last) {
+      return 'universal';
+    } else if (last.match(match.ID)) {
       return 'id';
     } else if (last.match(match.CLASS)) {
       return 'class';
@@ -99,8 +101,11 @@
     var score = 1;
     var messages = [];
 
+    if (!last) {
+    }
+
     // ID category
-    if (last.match(match.ID)) {
+    else if (last.match(match.ID)) {
       // Check for redundant class name
       if (last.match(match.CLASS)) {
         messages.push("ID is overly qualified by a class name");

diff --git a/test.js b/test.js
@@ -146,6 +146,8 @@ exports.category = {
 };
 
 exports.specificity = function(test) {
+  test.deepEqual(cssExplain("").specificity, [0, 0, 0]);
+
   test.deepEqual(cssExplain("*").specificity, [0, 0, 0]);
   test.deepEqual(cssExplain("li").specificity, [0, 0, 1]);
   test.deepEqual(cssExplain("li:first-line").specificity, [0, 0, 2]);