Skip to content

Commit e83034a

Browse files
committed
Inline some more kwargs into setup.py's setup() call.
- long_description can be defined right where it's used. - It seems nicer to also define classifiers at the point of use (together with other "metadata"-like entries) rather than at the top of the file, far away from the point of use.
1 parent bb7f9b9 commit e83034a

File tree

1 file changed

+15
-21
lines changed

1 file changed

+15
-21
lines changed

setup.py

+15-21
Original file line numberDiff line numberDiff line change
@@ -73,21 +73,6 @@
7373
]
7474

7575

76-
classifiers = [
77-
'Development Status :: 5 - Production/Stable',
78-
'Framework :: Matplotlib',
79-
'Intended Audience :: Science/Research',
80-
'Intended Audience :: Education',
81-
'License :: OSI Approved :: Python Software Foundation License',
82-
'Programming Language :: Python',
83-
'Programming Language :: Python :: 3',
84-
'Programming Language :: Python :: 3.6',
85-
'Programming Language :: Python :: 3.7',
86-
'Programming Language :: Python :: 3.8',
87-
'Topic :: Scientific/Engineering :: Visualization',
88-
]
89-
90-
9176
class NoopTestCommand(TestCommand):
9277
def __init__(self, dist):
9378
print("Matplotlib does not support running tests with "
@@ -222,10 +207,6 @@ def run(self):
222207
with open('lib/matplotlib/mpl-data/matplotlibrc', 'w') as fd:
223208
fd.write(''.join(template_lines))
224209

225-
# Use Readme as long description
226-
with open('README.rst', encoding='utf-8') as fd:
227-
long_description = fd.read()
228-
229210
# Finally, pass this all along to distutils to do the heavy lifting.
230211
setup(
231212
name="matplotlib",
@@ -242,10 +223,24 @@ def run(self):
242223
'Forum': 'https://discourse.matplotlib.org/',
243224
'Donate': 'https://numfocus.org/donate-to-matplotlib'
244225
},
245-
long_description=long_description,
226+
long_description=Path("README.rst").read_text(encoding="utf-8"),
246227
long_description_content_type="text/x-rst",
247228
license="PSF",
248229
platforms="any",
230+
classifiers=[
231+
'Development Status :: 5 - Production/Stable',
232+
'Framework :: Matplotlib',
233+
'Intended Audience :: Science/Research',
234+
'Intended Audience :: Education',
235+
'License :: OSI Approved :: Python Software Foundation License',
236+
'Programming Language :: Python',
237+
'Programming Language :: Python :: 3',
238+
'Programming Language :: Python :: 3.6',
239+
'Programming Language :: Python :: 3.7',
240+
'Programming Language :: Python :: 3.8',
241+
'Topic :: Scientific/Engineering :: Visualization',
242+
],
243+
249244
package_dir={"": "lib"},
250245
packages=find_packages("lib"),
251246
namespace_packages=["mpl_toolkits"],
@@ -254,7 +249,6 @@ def run(self):
254249
# real extensions that can depend on numpy for the build.
255250
ext_modules=[Extension("", [])],
256251
package_data=package_data,
257-
classifiers=classifiers,
258252

259253
python_requires='>={}'.format('.'.join(str(n) for n in min_version)),
260254
setup_requires=[

0 commit comments

Comments
 (0)