Skip to content
This repository has been archived by the owner on Aug 3, 2023. It is now read-only.

Add Typescript types #4

Closed
RodolfoSilva opened this issue Jan 30, 2021 · 2 comments · Fixed by #5
Closed

Add Typescript types #4

RodolfoSilva opened this issue Jan 30, 2021 · 2 comments · Fixed by #5
Labels
Feature New feature or request

Comments

@RodolfoSilva
Copy link
Contributor

I think we can add Typescript types or move the project to use Typescript.

If you're interested in it, I can do it today @jrgarciadev. I'm using this lib on a project I'm working on.

@jrgarciadev
Copy link
Owner

Hey @RodolfoSilva thanks for your contribution, I'm going to review your changes.

@jrgarciadev
Copy link
Owner

Hey @RodolfoSilva, I was reviewing your PR, but there is a problem, the file "react-iconly.d.ts" should be in the "dist" folder so that later it can be distributed in the npm package, so you must add the command to compile typescript next to the command to do the build something like this "build": "microbundle && tsc" and "tsconfig.json" file, could you guide yourself with this post

Thanks!

@jrgarciadev jrgarciadev added the Feature New feature or request label Mar 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants