-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeno IMproved #153
Comments
ecyclopaedias => encyclopaedias? |
Good catch! Fixed (currently in this issue only), thanks. |
This is a British spelling. See https://en.wikipedia.org/wiki/Encyclopedia:
and https://www.merriam-webster.com/dictionary/encyclopaedia:
I thought that we prefer American spelling for KS identifiers, don't we? In fact, @KOLANICH suggested this himself in kaitai-io/kaitai_struct#522 (comment):
|
Please don't rip out of context. That suggestion was in context of units. Units are the things that must be uniform, and most of units libraries use American spelling for a meter (though some support both), so introducing there In identifiers it probably makes sense to use American spelling only when the word with variability was introduced by spec author and if an another part of the Also, |
I don't think so. Quite often, it doesn't make sense to blindly and thoughtlessly follow the style and internal conventions of the reference spec (see examples in the style guide). We want to ensure consistency, predictability and intelligibility of the formats in KSF, so we should follow stable style and conventions for KSY specs rather than conventions of anything else. If a spec for one image format uses color, then what's the point of using colour in another one? For illustration, here's how it looks if you don't set any conventions: kaitai_struct_formats/image/icc_4.ksy Lines 32 to 34 in c7658a6
In an ideal world, same things should be called the same and different things differently, and not only within one specification, but also across all. That's why it makes sense to normalize
Perhaps. But that does not justify using different spelling in
Yes, that's exactly the problem - it's cool, stylish and definitely not monotonous. That's why it distracts attention - you're attracted by the unconventional spelling and not focused on the actual content. |
i.e. when software name has the word
Clearly a bug - the wording is used inconsistently without a proper justification to do so.
Not quite. I feel like the pieces that are quotes should retain the original spelling. Especially if they are quotes within text literals marked as such, i.e. with I.e. in software with the token meta:
id: ..._colour_...
title: ... Color Format
application: ... Colour ...
doc: |
... color ...
The doc says:
> ... colour ...
seq:
...
- id: color
... |
The text was updated successfully, but these errors were encountered: