Feature request: support for modify

[nitnelave]

Hi!

First of all, thanks a lot for your crate, it's been very useful to create my own tiny LDAP server for user management: https://github.com/nitnelave/lldap

However, something that's missing for transparent integration with e.g. Authelia is the ability to reset the user's password from the LDAP interface. That would require the LdapModify message from this crate.

I haven't tested it, but the README says that it's not supported. However, in the code I still see some implementation of LdapModify. Is it complete? Do you need help with it?

Cheers,

[Firstyear]

No problem! I'm glad it's been helpful.

LdapModify does fully work, I will update the readme! What you are likely going to be missing though is the password modify extended operation : https://ldapwiki.com/wiki/Password%20Modify%20Extended%20Operation

So that will likely need to be added.

[nitnelave]

Oh nice, great that the modification operations are supported! You're definitely underselling the project with the out of date readme :)

Yes, it sounds like the extended password modification would be required. If you need, i can do a test with Authelia and my server to see if it works with the current modification operations, but you're probably right

[Firstyear]

I have updated the readme now, to hopefully properly sell the project :D

I would be happy for you to test with your application and to give feedback about what does / does not work. Would you be able/willing to work on extending the library for the pw change extop? Or would that be something youd prefer me to do for you and you can test it for me? Thanks!

[nitnelave]

I had a look at the code, it doesn't seem all that complicated, but it just reflects long hours spent reading the RFCs :)

I don't have that much time right now so I'm not sure when I'd get to it, it may be randomly this month or it may have to wait until October.

I think it'd much more efficient if you implement it and I test it, if you don't mind. You know your code much better than me.