Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to ignore unknown controls #57

Closed
MDM23 opened this issue Jul 25, 2024 · 6 comments · Fixed by #58
Closed

Possibility to ignore unknown controls #57

MDM23 opened this issue Jul 25, 2024 · 6 comments · Fixed by #58

Comments

@MDM23
Copy link
Contributor

MDM23 commented Jul 25, 2024

I'm currently encountering the same difficulties as mentioned in #28. A client that needs to connect to my server sends a control with OID 1.3.6.1.4.1.6666.5327.2 within the bind request. I cannot find any information about this specific control, but it prevents me from handling the authentication.

Basically, I would just need the changes which were done in #30. Would there still be a possibility to implement something like this? If that's to specific, just let me know. I could just create an own fork for that use-case.

@Firstyear
Copy link
Member

So the reason I don't want to ignore unknowns is because it's better to be aware of what controls might be requested, and that we may need to implement them.

If we allow ignoring I'd say it should be a cfg flag, but still unsure about it.

Doing some research, that control doesn't appear to have any defined specification or references so I wonder what it is ....

@nitnelave
Copy link
Collaborator

I would argue that the decision of what to do with unknown controls rests with the application. Reporting a list of unknown/unparsed controls with a query sounds like a good compromise. If it's important to the application, they can log an error (rather than fail to parse), or refuse to process the message. And they'll have the OID of the missing control.

@Firstyear
Copy link
Member

After some thought, I think you're right @nitnelave. I'm happy to accept the PR allowing unknown controls.

@nitnelave
Copy link
Collaborator

@MDM23 I won't have time to work on that, do you want to prepare a PR?

@MDM23
Copy link
Contributor Author

MDM23 commented Jul 26, 2024

@nitnelave Sure, I'll take care of it! 👍

@MDM23
Copy link
Contributor Author

MDM23 commented Jul 26, 2024

Doing some research, that control doesn't appear to have any defined specification or references so I wonder what it is ....

Not sure what it is actually used for. The client is an Ascom IP DECT Base Station. A parent OID is registered here but there is no hint about what 5327.2 means. So I think they just use this internally when talking to one of their own services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants