Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for non-UTF8 attributes #7

Closed
nitnelave opened this issue Aug 7, 2022 · 2 comments
Closed

Add support for non-UTF8 attributes #7

nitnelave opened this issue Aug 7, 2022 · 2 comments

Comments

@nitnelave
Copy link
Collaborator

Currently, LdapPartialAttributes require the values to be String, i.e. a valid UTF-8 attribute.

However, a fairly common LDAP attribute is JpegPhoto where the raw bytes of the JpegPhoto are sent. It's not representable as a String. It should instead be a OsString or Vec<u8>.

WDYT? If you want this (it would be a breaking change, I understand) I can try to work on a PR, but otherwise I'll just have my own fork.

@Firstyear
Copy link
Member

I think you're right, we should represent this as a Vec. I'd be happy to review and help with the PR :)

@Firstyear
Copy link
Member

@nitnelave Sorry for the huge delay on this. I'm going to make this change within the week and will update to 0.3 to resolve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants