Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding global "Promise" #171

Closed
blacha opened this issue Dec 6, 2015 · 4 comments
Closed

Overriding global "Promise" #171

blacha opened this issue Dec 6, 2015 · 4 comments

Comments

@blacha
Copy link

blacha commented Dec 6, 2015

Loading the npm task "grunt-karma" destroys the global "Promise" variable.

running on Node v4.1.0

Gruntfile.js:

module.exports = function (grunt) {
    console.log('before-karma', Promise.defer);
    grunt.loadNpmTasks('grunt-karma');
    console.log('after-karma', Promise.defer);
}

Output:

before-karma function defer() { [native code] }
after-karma undefined
@ogonkov
Copy link

ogonkov commented Feb 29, 2016

Seems this breaks grunt-postcss task nDmitry/grunt-postcss#87

Possible duplicate of #170

@dignifiedquire
Copy link
Member

@ogonkov this is not an issue of karma but a bug in the promise implementation. Ref karma-runner/karma#1946

@ogonkov
Copy link

ogonkov commented Feb 29, 2016

@dignifiedquire thank you for sorting out that!

@Krinkle
Copy link
Collaborator

Krinkle commented Aug 27, 2018

Closing in favour of karma-runner/karma#1946.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants