-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please remove grunt from peerDependencies from package.json #185
Comments
@paladox this is already done, having the In your project you are using |
See 0.12.1 version https://github.com/karma-runner/grunt-karma/blob/v0.12.1/package.json#L47 and compare it with |
Thanks ive asked for this to be released as a 0.12.2 update. |
@vladikoff Actually see gruntjs/grunt-contrib-watch@1f198f6 Still causing 19:34:58 npm ERR! peerinvalid The package grunt does not satisfy its siblings' peerDependencies requirements! Now its one module less since updating watch which had peer but removed it in 1.x update. |
@paladox Yeah you can both remove and keep it. Some developers prefer to keep this setting. |
@vladikoff do you suggest to keep it, how would we support 1.0 of grunt. |
Please |
Plugins that will have >=0.4.0 as a peerDep will just work: ( |
@vladikoff Oh ok thanks. So its grunt that the problem. Should we file a task with them. |
Ive reported it here gruntjs/grunt#1488 |
New version released which should fix this |
Thanks. |
Please fix peerDependencies since it is failing grunt 1.0.0
Update
"peerDependencies": {
"grunt": ">=0.4.x"
},
to
"peerDependencies": {
"grunt": ">=0.4.0"
},
@dignifiedquire or @vladikoff Please could you do it since I doint want to sign the cla.
The text was updated successfully, but these errors were encountered: