Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove grunt from peerDependencies from package.json #185

Closed
paladox opened this issue Mar 17, 2016 · 13 comments
Closed

Please remove grunt from peerDependencies from package.json #185

paladox opened this issue Mar 17, 2016 · 13 comments

Comments

@paladox
Copy link

paladox commented Mar 17, 2016

Please fix peerDependencies since it is failing grunt 1.0.0

Update
"peerDependencies": {
"grunt": ">=0.4.x"
},

to

"peerDependencies": {
"grunt": ">=0.4.0"
},

@dignifiedquire or @vladikoff Please could you do it since I doint want to sign the cla.

@vladikoff
Copy link
Contributor

@paladox this is already done, having the "grunt": ">=0.4.x", is good enough.

In your project you are using [email protected] that wants [email protected] which still had "grunt": "0.4.x"

@vladikoff
Copy link
Contributor

See 0.12.1 version https://github.com/karma-runner/grunt-karma/blob/v0.12.1/package.json#L47 and compare it with master

@vladikoff
Copy link
Contributor

@paladox
Copy link
Author

paladox commented Mar 17, 2016

Thanks ive asked for this to be released as a 0.12.2 update.

@paladox
Copy link
Author

paladox commented Mar 17, 2016

@vladikoff Actually see gruntjs/grunt-contrib-watch@1f198f6

Still causing

19:34:58 npm ERR! peerinvalid The package grunt does not satisfy its siblings' peerDependencies requirements!
19:34:58 npm ERR! peerinvalid Peer [email protected] wants grunt@>=0.4.0
19:34:58 npm ERR! peerinvalid Peer [email protected] wants grunt@>=0.4.0
19:34:58 npm ERR! peerinvalid Peer [email protected] wants [email protected]
19:34:58

Now its one module less since updating watch which had peer but removed it in 1.x update.

@vladikoff
Copy link
Contributor

@paladox Yeah you can both remove and keep it. Some developers prefer to keep this setting.

@paladox
Copy link
Author

paladox commented Mar 17, 2016

@vladikoff do you suggest to keep it, how would we support 1.0 of grunt.

@paladox
Copy link
Author

paladox commented Mar 17, 2016

Please

@paladox paladox changed the title Please remove Please remove peerDependencies from package.json Mar 17, 2016
@paladox paladox changed the title Please remove peerDependencies from package.json Please remove grunt from peerDependencies from package.json Mar 17, 2016
@vladikoff
Copy link
Contributor

@vladikoff do you suggest to keep it, how would we support 1.0 of grunt.

Plugins that will have >=0.4.0 as a peerDep will just work:

image

(rc1 is currently failing but that's npm's fault)

@paladox
Copy link
Author

paladox commented Mar 17, 2016

@vladikoff Oh ok thanks. So its grunt that the problem. Should we file a task with them.

@paladox
Copy link
Author

paladox commented Mar 17, 2016

Ive reported it here gruntjs/grunt#1488

@dignifiedquire
Copy link
Member

New version released which should fix this

@paladox
Copy link
Author

paladox commented Mar 17, 2016

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants