Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems with LabelsOverrider #6067

Closed
guozheng-shen opened this issue Jan 20, 2025 · 12 comments
Closed

Problems with LabelsOverrider #6067

guozheng-shen opened this issue Jan 20, 2025 · 12 comments
Labels
kind/question Indicates an issue that is a support question.

Comments

@guozheng-shen
Copy link
Contributor

Please provide an in-depth description of the question you have:
When we use Karmada to propagate Deployments、StatefulSets to member clusters, I want to add a label <cluster: {memberCluster}> to our resources. But labelsOverrider only supports adding a certain value. What can I do.

What do you think about this question?:
Can we use an expression like ${.memberCluster}, and let Karmada auto inject the real value into the label?

Environment:

  • Karmada version: 1.19
  • Kubernetes version: 1.28
  • Others:
@guozheng-shen guozheng-shen added the kind/question Indicates an issue that is a support question. label Jan 20, 2025
@RainbowMango
Copy link
Member

Why do you have to label your resources with a dynamic cluster name?

Karmada version: 1.19

By the way, Karmada hasn't released v1.19 yet.

@guozheng-shen
Copy link
Contributor Author

Why do you have to label your resources with a dynamic cluster name?

Karmada version: 1.19

By the way, Karmada hasn't released v1.19 yet.

sorry, version is 1.9

@guozheng-shen
Copy link
Contributor Author

Why do you have to label your resources with a dynamic cluster name?

Karmada version: 1.19

By the way, Karmada hasn't released v1.19 yet.

other systems need get member cluster from label

@RainbowMango
Copy link
Member

Sorry, I still don't get the use case like why the other systems needs the member cluster, and what they do with these cluster names.

@guozheng-shen
Copy link
Contributor Author

Sorry, I still don't get the use case like why the other systems needs the member cluster, and what they do with these cluster names.

For example, we need to synchronize our instance info to our name service and cmdb. The instance info needs a cluster name. All of our existing processes are implemented through labels. If we want to make modifications, it requires cooperation from other teams, and it's difficult.

@guozheng-shen
Copy link
Contributor Author

we are going to use webhooks to achieve the goal

@guozheng-shen
Copy link
Contributor Author

Thanks @RainbowMango

@RainbowMango
Copy link
Member

By the way, are you using Karmada now?

@guozheng-shen
Copy link
Contributor Author

guozheng-shen commented Jan 22, 2025

By the way, are you using Karmada now?

Yes, this is our arch https://github.com/karmada - io/karmada/issues/5103. Each region contains two or more karmada clusters for ha. However, only the specified ca-cert and ca-key have a small problem when monitoring. We need to add the --service - account-key-file={other karmada cluster karmada.key} flag in the karmada-apiserver start command. if not the Prometheus agent will get a 401 error when collecting metrics

@RainbowMango
Copy link
Member

Great! Glad to hear from you. May I know your company name? Is it presented on the Adopter list? https://karmada.io/adopters

@guozheng-shen
Copy link
Contributor Author

Tongcheng Travel, It's inside.

@RainbowMango
Copy link
Member

OK. You are welcome to join the Adopter Group, you can get more details on the linked doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Indicates an issue that is a support question.
Projects
None yet
Development

No branches or pull requests

2 participants