Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastlogger OOM's when setting log_backup_number to maxBound on logfile rotation #212

Open
jappeace opened this issue Mar 7, 2024 · 1 comment

Comments

@jappeace
Copy link

jappeace commented Mar 7, 2024

Recently keter was moved over to fastlogger,
we set the LogFile limit conservatively to maxInt to make sure it doesn't lose information.

https://github.com/snoyberg/keter/blob/28ba9b538b9e3850922c5e59a8e3038425a11f9a/src/Keter/Logger.hs#L51

Now we got a bugreport that it crashes on any rotation.
snoyberg/keter#288

I'll work around this by setting it to 20.

@jappeace jappeace changed the title Fastlogger OOM's when setting log_backup_number to maxBound Fastlogger OOM's when setting log_backup_number to maxBound on logfile rotation Mar 7, 2024
@kazu-yamamoto
Copy link
Owner

I can remove reverse from rotate but n must not be huge anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants