Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certain generated epubs do not read with google books #41

Open
mrothbart opened this issue Sep 8, 2020 · 3 comments
Open

Certain generated epubs do not read with google books #41

mrothbart opened this issue Sep 8, 2020 · 3 comments

Comments

@mrothbart
Copy link

Heretical edge, Vacant Throne, Fifth Defiance, saga of soul all produce ebooks that can be read with calibre but not google books. I am unclear as to why that is.

Deathworlders simply errors out without producing anything.

@kemayo
Copy link
Owner

kemayo commented Sep 9, 2020

I don't have easy access to google books to test this -- is it very unfriendly to epubs with minor validation errors? The approach taken here of downloading arbitrary HTML and cramming it into an epub makes it easy to wind up with e.g. unsupported properties.

kemayo added a commit that referenced this issue Sep 9, 2020
This is `fb:like` and similar, which break some epub readers.

Refs: #41, #43
@kemayo
Copy link
Owner

kemayo commented Sep 9, 2020

Saga of Soul had some obvious issues with namespaced elements, so I added some filtering for that. Vacant Throne had some messed up indexing which might have been confusing matters, I guess? So I fixed its example somewhat.

@mrothbart
Copy link
Author

What I did to create a valid Vacant THrone epub was to save the HTML in a file, strip all href and tags besides for the ToC, then serve it locally from a WSL server and point the script at it. It worked great, but obviously not scalable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants