Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection leak possibility on some plugin tasks #1227

Closed
loicmathieu opened this issue May 4, 2023 · 1 comment
Closed

Connection leak possibility on some plugin tasks #1227

loicmathieu opened this issue May 4, 2023 · 1 comment
Labels
area/backend Needs backend code changes bug Something isn't working kind/cooldown Great candidate for the cooldown period

Comments

@loicmathieu
Copy link
Member

loicmathieu commented May 4, 2023

Expected Behavior

Using try/catch on connection instantiation eveywhere to avoid possible connection leak

Actual Behaviour

Plugins that open connection usually don't do it in a reliant manner using try/catch/finally risking connection leak in case of exception.

An example can be found in the Kafka Consume task.

We need to check all connection-based plugins for such issues

@loicmathieu loicmathieu added the bug Something isn't working label May 4, 2023
@github-project-automation github-project-automation bot moved this to Backlog in All issues May 4, 2023
@tchiotludo tchiotludo added this to the 0.10.0 milestone May 4, 2023
@Ben8t Ben8t modified the milestones: 0.10.0, 0.11.0 May 17, 2023
@tchiotludo tchiotludo removed this from the 0.11.0 milestone Aug 28, 2023
@anna-geller anna-geller added this to the v0.17.0 milestone Dec 5, 2023
@anna-geller anna-geller removed this from All issues Dec 12, 2023
@anna-geller anna-geller modified the milestones: v0.17.0, v0.19.0 Apr 17, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Jun 10, 2024
@anna-geller anna-geller removed this from the v0.19.0 milestone Jul 23, 2024
@anna-geller anna-geller added the kind/cooldown Great candidate for the cooldown period label Aug 15, 2024
@Ben8t Ben8t removed the bug Something isn't working label Feb 13, 2025
@anna-geller anna-geller added bug Something isn't working area/backend Needs backend code changes labels Feb 18, 2025
@anna-geller
Copy link
Member

closing since this was open for ~2 years

@loicmathieu feel free to reopen with more details if this is still relevant

@anna-geller anna-geller closed this as not planned Won't fix, can't repro, duplicate, stale Feb 18, 2025
@github-project-automation github-project-automation bot moved this from Backlog to Done in Issues Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/backend Needs backend code changes bug Something isn't working kind/cooldown Great candidate for the cooldown period
Projects
Status: Done
Development

No branches or pull requests

4 participants