Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Debug Outputs section to be resizable #5843

Closed
anna-geller opened this issue Nov 7, 2024 · 19 comments
Closed

Change the Debug Outputs section to be resizable #5843

anna-geller opened this issue Nov 7, 2024 · 19 comments
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors

Comments

@anna-geller
Copy link
Member

anna-geller commented Nov 7, 2024

Feature description

Some expressions or outputs are large. It would be great to make this Debug Outputs section as a resizable component:

image

Extra info for first-time contributors

You can reproduce it by adding this flow, running it and navigating to Outputs:

id: hello-world
namespace: dev
description: Hello World
inputs:
  - id: user
    type: STRING
    defaults: Rick Astley
tasks:
  - id: first_task
    type: io.kestra.plugin.core.debug.Return
    format: thrilled
  - id: second_task
    type: io.kestra.plugin.scripts.shell.Commands
    commands:
      - sleep 0.42
      - echo '::{"outputs":{"returned_data":"mydata"}}::'
  - id: hello_world
    type: io.kestra.plugin.core.log.Log
    message: |
      Welcome to Kestra, {{ inputs.user }}! 
      We are {{ outputs.first_task.value}} to have You here!
@anna-geller anna-geller added enhancement New feature or request area/frontend Needs frontend code changes good first issue Great issue for new contributors labels Nov 7, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Issues Nov 7, 2024
@osmaneTKT
Copy link
Contributor

Hello @anna-geller some time ago I came across this project and I would like to contribute to it as part of a course requirement for my computer science degree.

@MilosPaunovic
Copy link
Member

That's awesome, go for it @osmaneTKT! 🚀

@satvik2131
Copy link
Contributor

can i use vue-resizable
https://www.npmjs.com/package/vue-resizable
or if we have any better suggestions , I would like to implement .

@anna-geller
Copy link
Member Author

I don't know how it's technically implemented, but you could try using the same component that we use within the editor, see https://share.descript.com/view/p5vqgmD53pw

@osmaneTKT
Copy link
Contributor

@satvik2131 I'm working on it.

@osmaneTKT
Copy link
Contributor

Hello @anna-geller , I think I managed to solve the problem.

@MilosPaunovic
Copy link
Member

@osmaneTKT You've opened two PRs about this, could you check which one is the right one and close the other one?

@osmaneTKT
Copy link
Contributor

Sorry, I hadn't noticed.

@osmaneTKT
Copy link
Contributor

osmaneTKT commented Nov 21, 2024

hey @MilosPaunovic , do i need to do anything else ?

@MilosPaunovic
Copy link
Member

Not sure, would need to review the PR first, and that's probably going to happen next week. Will let you know, it's on a TODO list.

@osmaneTKT
Copy link
Contributor

thanks

@MilosPaunovic
Copy link
Member

Thanks for the efforts @osmaneTKT, but the solution was not what we were aiming for.

If someone else want to try this, check out how it's done inside kestra/ui/src/components/Tabs.vue component, and I've added a slider and placeholder method to kestra/ui/src/components/executions/outputs/Wrapper.vue file, where the change needs to be done.

@ArmandoJA
Copy link

Hello @MilosPaunovic I would like your permission to give this issue a try as part of a course activity for one of my CS classes.

@MilosPaunovic
Copy link
Member

MilosPaunovic commented Jan 17, 2025

Absolutely, go for it @ArmandoJA, will wait for your PR! 🚀

@MilosPaunovic
Copy link
Member

Hi @ArmandoJA,

As there hasn't been any progress or updates on this, I'll unassign you for now. However, if you do open a PR, it will be reviewed, and you'll be reassigned if no one else handles it in the meantime.

Thanks for all the efforts so far! 🍀

@Alessandra005
Copy link

Hi @MilosPaunovic, I would like to help with this issue if it's still available, can I?

@MilosPaunovic
Copy link
Member

Certainly, go ahead @Alessandra005! 🚀

Alessandra005 added a commit to Alessandra005/kestra that referenced this issue Feb 15, 2025
Change the Debug Outputs section to be resizable  kestra-io#5843

This PR introduces a resizable Debug Outputs section in the UI, allowing users to adjust its height dynamically. The implementation follows the approach used for the existing resizable left panel.

Changes Made:
- Implemented a resizable feature for the Debug Outputs section.
- Outputs height, with bounds between 20% and 80%.
@Alessandra005
Copy link

Hey, I’ve been working on the issue, and I just submitted a PR for it. Let me know if any changes are needed, and I’ll be happy to adjust! 🚀

@MilosPaunovic
Copy link
Member

This is already closed via #7377, as part of #7242.

Thanks for the efforts, @Alessandra005! 🚀

@github-project-automation github-project-automation bot moved this from Backlog to Done in Issues Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/frontend Needs frontend code changes enhancement New feature or request good first issue Great issue for new contributors
Projects
Status: Done
Development

No branches or pull requests

6 participants