Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dx and dy are nil on collision on the 2.0 branch #5

Closed
tanema opened this issue Apr 30, 2014 · 2 comments
Closed

dx and dy are nil on collision on the 2.0 branch #5

tanema opened this issue Apr 30, 2014 · 2 comments

Comments

@tanema
Copy link

tanema commented Apr 30, 2014

Hey, First of thanks for all the work you've done it is really great.

So I am trying to use your 2.0 version of bump because I like its minimal approach however on all the collisions, dx and dy are nil. If I use the bump.lua from the demo2.0 branch though, everything is functional.

I understand that 2.0 probably isnt stable yet I just thought you would like to know.

PS you can test this out with the code from my game template here: https://github.com/tanema/love_game

if test/bump.lua (from demo2.0) is required in main everything is functional but if bump is included from vendor/bump/bump.lua then it breaks when there is a collision.

Cheers.

@kikito
Copy link
Owner

kikito commented Apr 30, 2014

Hi Tim,

Thanks for the bug report!

Yes, the 2.0 branch is still unfinished. I try to develop it with tests, but sometimes it's just more efficient to "try" the code in a demo and see if something breaks. I might have added new features on the 2.0 branch that are not compatible with the demo, or I might have fixed something in the demo and forgot to move it to the 2.0 branch. I will give it a look cheers!

@kikito
Copy link
Owner

kikito commented May 5, 2014

Hi Tim,

I spent a good chunk of this weekend reviewing the state of bump.lua (most of the time was spent chasing a particularly nasty bug).

I have good news and bad news for you.

The good news is that the demo2.0 branch now works the same way that the 2.0 branch works.

The bad news is that this was not done by copying what was on demo2.0 to 2.0, but the other way around.

On bump 2.0 the way things are done changes almost completely from the 1.0 way. I am going to expand the demo to make sure that all the features of the lib are displayed and tested (I will add some enemies and some fast-moving bouncing bullets). Then I will update the README to explain how things are done on this new 2.0 branch. But if you want to give it a try, have a look at player.lua in the demo2.0 branch.

Since this explains your original question (the differences between 2.0 and demo2.0), I'm closing down this issue.

@kikito kikito closed this as completed May 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants