Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emailAddress parser calls getHostName when domain is empty #235

Closed
etam opened this issue Jan 1, 2020 · 1 comment · Fixed by #287
Closed

emailAddress parser calls getHostName when domain is empty #235

etam opened this issue Jan 1, 2020 · 1 comment · Fixed by #287

Comments

@etam
Copy link

etam commented Jan 1, 2020

According to RFC2822 section 3.4.1:

An addr-spec is a specific Internet identifier that contains a
locally interpreted string followed by the at-sign character ("@",
ASCII value 64) followed by an Internet domain.

For some reason vmime allows empty domain or even a lack of '@' sign. Instead vmime asks DNS for local hostname.

https://github.com/kisli/vmime/blob/b55bdc9/src/vmime/emailAddress.cpp#L543-L546

For me an expected behavior is that any parser should not make any network connections. Additionally if domain part is missing, it should be a parsing error.

@bmagistro
Copy link
Contributor

I just got hit with this. Will try to get the patch put into a PR over the next day or two. May need to untangle it from other open PRs/patches we have applied first.

@vincent-richard vincent-richard linked a pull request Dec 31, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants