Skip to content

Commit 2970af2

Browse files
committed
unskip test_exceptions.py
1 parent 0aa1388 commit 2970af2

File tree

2 files changed

+12
-6
lines changed

2 files changed

+12
-6
lines changed

Lib/test/test_exception_hierarchy.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,8 @@ def test_socket_errors(self):
4949
self.assertIs(socket.herror.__base__, OSError)
5050
self.assertIs(socket.timeout.__base__, OSError)
5151

52-
@unittest.skip("TODO: RUSTPYTHON")
52+
# TODO: RUSTPYTHON
53+
@unittest.expectedFailure
5354
def test_select_error(self):
5455
self.assertIs(select.error, OSError)
5556

Lib/test/test_exceptions.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,8 @@ def raise_catch(self, exc, excname):
4141
self.assertEqual(buf1, buf2)
4242
self.assertEqual(exc.__name__, excname)
4343

44-
@unittest.skip("TODO: RUSTPYTHON")
44+
# TODO: RUSTPYTHON
45+
@unittest.expectedFailure
4546
def testRaising(self):
4647
self.raise_catch(AttributeError, "AttributeError")
4748
self.assertRaises(AttributeError, getattr, sys, "undefined_attribute")
@@ -331,7 +332,8 @@ def test_windows_message(self):
331332
with self.assertRaisesRegex(OSError, 'Windows Error 0x%x' % code):
332333
ctypes.pythonapi.PyErr_SetFromWindowsErr(code)
333334

334-
@unittest.skip("TODO: RUSTPYTHON")
335+
# TODO: RUSTPYTHON
336+
@unittest.expectedFailure
335337
def testAttributes(self):
336338
# test that exception attributes are happy
337339

@@ -489,7 +491,8 @@ def testInvalidTraceback(self):
489491
else:
490492
self.fail("No exception raised")
491493

492-
@unittest.skip("TODO: RUSTPYTHON")
494+
# TODO: RUSTPYTHON
495+
@unittest.expectedFailure
493496
def testInvalidAttrs(self):
494497
self.assertRaises(TypeError, setattr, Exception(), '__cause__', 1)
495498
self.assertRaises(TypeError, delattr, Exception(), '__cause__')
@@ -1232,7 +1235,8 @@ def __del__(self):
12321235
self.assertIn("del is broken", report)
12331236
self.assertTrue(report.endswith("\n"))
12341237

1235-
@unittest.skip("TODO: RUSTPYTHON")
1238+
# TODO: RUSTPYTHON
1239+
@unittest.expectedFailure
12361240
def test_unhandled(self):
12371241
# Check for sensible reporting of unhandled exceptions
12381242
for exc_type in (ValueError, BrokenStrException):
@@ -1389,7 +1393,8 @@ def test_non_str_argument(self):
13891393
exc = ImportError(arg)
13901394
self.assertEqual(str(arg), str(exc))
13911395

1392-
@unittest.skip("TODO: RUSTPYTHON")
1396+
# TODO: RUSTPYTHON
1397+
@unittest.expectedFailure
13931398
def test_copy_pickle(self):
13941399
for kwargs in (dict(),
13951400
dict(name='somename'),

0 commit comments

Comments
 (0)