Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider eliminating use of requests for remote workflow functionality #29

Open
applio opened this issue Dec 6, 2020 · 1 comment
Open
Labels
bug Something isn't working

Comments

@applio
Copy link
Collaborator

applio commented Dec 6, 2020

With the merging of PR #12, there is now a dependency on the requests module for remote workflow functionality. While the use of this popular module is very appropriate, it does deviate from the goal of having knime.py not depend upon anything outside of Python itself. Even the pandas module is purely optional but when it comes to remote workflow functionality the same can not be said for requests.

Either this functionality should be supplied by the Python Standard Library's urllib.request and related modules or the stated goal of depending upon nothing more than a standard Python installation should be updated.

@applio applio added the bug Something isn't working label Dec 6, 2020
@greglandrum
Copy link
Collaborator

my two cents: I'm not sure what it would look like in this particular case, but in my experience code written with requests tends to be considerably simpler and easier to read than the alternatives using the standard library. Given that requests is actively maintained and widely used, I think it makes sense to continue to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants