Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CSV parsing in DataFrame #135

Closed
Merlin04 opened this issue Jun 13, 2021 · 1 comment
Closed

Improve CSV parsing in DataFrame #135

Merlin04 opened this issue Jun 13, 2021 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@Merlin04
Copy link
Member

let data: any[] = dataStr.split("\n");

Right now, we use String.split to parse CSVs, which isn't the best way to do it because it doesn't handle escaped values, newlines, or other variations on the CSV format (like TSV). We should use something like Papa Parse (what I use in better-react-spreadsheet) to do parsing for us.

@Merlin04 Merlin04 added enhancement New feature or request good first issue Good for newcomers labels Jun 13, 2021
@Merlin04
Copy link
Member Author

Fixed in #134

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant