Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce duplication in _block.ts files #46

Closed
Merlin04 opened this issue Oct 13, 2020 · 2 comments
Closed

Reduce duplication in _block.ts files #46

Merlin04 opened this issue Oct 13, 2020 · 2 comments
Assignees
@Merlin04
Labels
priority-2 Feature that is important to have but not crucial

Comments

@Merlin04
Copy link
Member

I'm finding that there's a lot of duplicate code in the _block.ts files, to make the one for RFRegression I just duplicated the RFClassifier one and changed the names. Any ideas on how we could reduce the amount of duplication?
@Merlin04 Merlin04 added help wanted Extra attention is needed priority-2 Feature that is important to have but not crucial and removed help wanted Extra attention is needed labels Oct 13, 2020
@Merlin04 Merlin04 self-assigned this Oct 13, 2020
@Merlin04
Copy link
Member Author

Merlin04 commented Nov 7, 2020

Almost done, just need to resolve a bug with the module import for LogReg

@Merlin04 Merlin04 mentioned this issue Nov 7, 2020
Closed
@Merlin04
Copy link
Member Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Merlin04 Merlin04

Labels
priority-2 Feature that is important to have but not crucial
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Merlin04