Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with GHC-8.6.1 #23

Closed
chshersh opened this issue Jul 19, 2018 · 8 comments
Closed

Build with GHC-8.6.1 #23

chshersh opened this issue Jul 19, 2018 · 8 comments
Assignees
Labels

Comments

@chshersh
Copy link
Contributor

No need to put on CI, but good to check locally at least.

@chshersh chshersh added the CI label Jul 19, 2018
@chshersh chshersh added this to the 0.1.0: ANN milestone Jul 19, 2018
@chshersh
Copy link
Contributor Author

Library builds with ghc-8.6.1 but tasty fails to build.

@chshersh chshersh removed this from the 0.1.0: ANN milestone Jul 21, 2018
@chshersh chshersh changed the title Check how it build with GHC-8.6.1 Check how it builds with GHC-8.6.1 Jul 29, 2018
@chshersh
Copy link
Contributor Author

I've tested again. It now builds. But doctest fails. Because something has changed in base.

@chshersh chshersh changed the title Check how it builds with GHC-8.6.1 Builds with GHC-8.6.1 Aug 14, 2018
@chshersh chshersh added this to the v0.2.0: More improvements milestone Aug 14, 2018
@vrom911
Copy link
Member

vrom911 commented Aug 14, 2018

I can't make it work. It seems not possible to build doctest without --allow-newer. Do you really think that it's a sane idea to put allow-newer?

@chshersh
Copy link
Contributor Author

@vrom911 No, we're not going to build relude with allow-newer. It should be buildable without allow-newer. It's a pity that doctest doesn't build with ghc-8.6.1 😞

Maybe it makes sense to create issue in doctest to track the status of building with GHC-8.6.1.
Looks like build with ghc-8.6.1 for relude is delayed for better times...

@chshersh chshersh removed this from the v0.2.0: More improvements milestone Aug 14, 2018
@chshersh chshersh changed the title Builds with GHC-8.6.1 Build with GHC-8.6.1 Aug 14, 2018
@chshersh
Copy link
Contributor Author

Tracking the status of the issue with doctest here:

@chshersh chshersh added this to the v0.3.0: Combinators milestone Aug 19, 2018
@vrom911
Copy link
Member

vrom911 commented Sep 7, 2018

Okay, the next stop is stm. Seems it's going to be released soon (?).
haskell/stm#16

@chshersh chshersh removed this from the v0.3.0: Combinators milestone Sep 8, 2018
@vrom911
Copy link
Member

vrom911 commented Sep 22, 2018

Updates: the library is building now 🎉
The problem now is tests, more accurate – doctest library. I've opened the PR in there, but it's very hard to say if it will be approved (and work).

@chshersh
Copy link
Contributor Author

@vrom911 Thanks for your effort! I hope that issue with doctest can be resolved soon... I would like to add support for GHC-8.6.1 to relude as soon as possible.

vrom911 added a commit that referenced this issue Sep 27, 2018
chshersh pushed a commit that referenced this issue Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants