Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The NonCommuting CommutingBehaviour can be ignored when canonicalizing expressions #90

Open
cls0 opened this issue Apr 17, 2018 · 1 comment
Labels
bug An actual bug
Milestone

Comments

@cls0
Copy link

cls0 commented Apr 17, 2018

If I understand correctly, consider this (v2.2.0):

{l_{#},m_{#}}::NonCommuting.
$l_{c} m_{b} l_{a}$;
canonicalise(_);

Here, we should not be able to commute each l through m without picking up some unknown commutators. However, this outputs l_{a} m_{b} l_{c}, suggesting that the algorithm assumes that, since l commutes with itself, this expression is symmetric in a,c. This sadly isn't sufficient, so we get the wrong answer.

Note that if alternatively l does not commute with itself, this issue is dodged:

l_{#}::SelfNonCommuting.
$l_{c} m_{b} l_{a}$;
canonicalise(_);

(Prints l_{c} m_{b} l_{a}.)

@kpeeters
Copy link
Owner

Thanks. This is a bug in core/Exchange.cc in get_node_gs, which should use Ex_comparator::can_move_adjacent but doesn't. Will fix.

@kpeeters kpeeters added this to the 2.2.8 milestone Mar 17, 2019
@kpeeters kpeeters added the bug An actual bug label Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An actual bug
Projects
None yet
Development

No branches or pull requests

2 participants