Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BulkUpdateByType returns an invalid reflect value #117

Open
kpelzel opened this issue Nov 15, 2019 · 1 comment
Open

BulkUpdateByType returns an invalid reflect value #117

kpelzel opened this issue Nov 15, 2019 · 1 comment
Labels
bug Something isn't working help wanted Extra attention is needed
Milestone

Comments

@kpelzel
Copy link
Contributor

kpelzel commented Nov 15, 2019

BulkUpdateByType creates a NewStateChangeEvent, but passes in an empty reflect value. This will result in the debug message containing an invalid reflect value.

https://github.com/hpc/kraken/blob/9dacb64ab6b0eaee8d8971e3fbcbd23f70a6c426/core/StateDifferenceEngine.go#L530

@jlowellwofford jlowellwofford added bug Something isn't working help wanted Extra attention is needed labels Jan 12, 2021
@jlowellwofford
Copy link
Contributor

This is actually pretty bad. It's because, unlike other events, it just passes an empty value. This is because it relies on the diff to generate events, and it would make the function a little heavier to get all of those values, but we should do it anyway...

@jlowellwofford jlowellwofford added this to the v0.2.1 milestone Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants