Merge pull request canonical#1 from canonical/feature/maxlifetime

Add MaxLifetime to connections so we react to leader changes

Author: ktsakalozos

pkg/drivers/generic/generic.go

@@ -85,6 +85,12 @@ type Generic struct {
 	TranslateErr          TranslateErr
 }
 
+func configureConnectionPooling(db *sql.DB) {
+	db.SetMaxIdleConns(5)
+	db.SetMaxOpenConns(5)
+	db.SetConnMaxLifetime(60 * time.Second)
+}
+
 func q(sql, param string, numbered bool) string {
 	if param == "?" && !numbered {
 		return sql
@@ -128,8 +134,6 @@ func openAndTest(driverName, dataSourceName string) (*sql.DB, error) {
 	if err != nil {
 		return nil, err
 	}
-	db.SetMaxIdleConns(5)
-	db.SetMaxOpenConns(5)
 
 	for i := 0; i < 3; i++ {
 		if err := db.Ping(); err != nil {
@@ -161,6 +165,8 @@ func Open(ctx context.Context, driverName, dataSourceName string, paramCharacter
 		}
 	}
 
+	configureConnectionPooling(db)
+
 	return &Generic{
 		DB: db,