Remove autoload so theme doesn't auto-apply when installing

[Trevoke]

I think that the autoload makes moe-light enabled when installing or updating, and the way it does it makes it impossible to disable the theme with "disable-theme", which leads the unwanted behavior.

[kuanyui]

Oops? I don't know that will lead a problem like this...
Indeed, I just try to install from MELPA and the problem occurs. But I don't sure this is where the problem at...
Ok, I'll remove autoload for a try in next updating.

[Trevoke]

I just wrote my first minor mode, so I'm learning about the autoload cookie. Here is an issue where someone explained to me how it works: Trevoke/sqlup-mode.el#6

I saw another theme that uses autoload, and it doesn't load the theme, but the theme is available:
https://github.com/marktran/color-theme-ujelly/blob/master/ujelly-theme.el

[Trevoke]

As of 20140701.450 (MELPA package), it still loads when you install from MELPA :/

[Trevoke]

I just installed the latest moe-theme and it still loads when upgrading from MELPA.

[duianto]

@kuanyui Could you take a look at this possible solution. It's an old issue so you might not have gotten a notification about my comment (maybe your unsubscribed from it or something).

This is still an issue.

moe-theme is part of the Spacemacs themes-megapack layer,
https://github.com/syl20bnr/spacemacs/blob/8c0b8c3440a33df2c291088c47e75fd5e4fbbb61/layers/%2Bthemes/themes-megapack/packages.el#L61

When all themes in the themes-megapack layer are being installed and it gets to moe-theme then it is applied automatically.

I don't know if it's the solution. But I noticed that moe-theme uses provide:

moe-theme.el/moe-theme.el

Line 508 in 6e086d8

(provide 'moe-theme)

While at least the four other themes that I've checked, use provide-theme:

• afternoon-theme (provide-theme 'afternoon)
• material-theme (provide-theme 'material)
• minimal-theme (provide-theme 'minimal)
• ujelly-theme (provide-theme 'ujelly)

The Emacs manual seems to also suggest provide-theme for custom themes:

A Custom theme file should be named foo-theme.el, where foo is the theme name. The first Lisp form in the file should be a call to deftheme, and the last form should be a call to provide-theme.

source: https://www.gnu.org/software/emacs/manual/html_node/elisp/Custom-Themes.html