Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

lets format the code in ci #377

Closed
jayunit100 opened this issue Oct 14, 2022 · 13 comments
Closed

lets format the code in ci #377

jayunit100 opened this issue Oct 14, 2022 · 13 comments
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@jayunit100
Copy link
Contributor

@astoycos thinks were CRAZY bc we dont gofmt EVERY SINGLE PR

lets make him happy :)

files to impl

hack/verify-gofmt.sh
hack/update-gofmt.sh
https://github.com/kubernetes-sigs/kpng/blob/master/.github/workflows/vet-code.yml
@jayunit100
Copy link
Contributor Author

/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@jayunit100:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Oct 14, 2022
@heisaman
Copy link

I'll fix it. 😃

@uablrek
Copy link
Contributor

uablrek commented Oct 15, 2022

Please remember;

CI or any plugin MUST NOT update the repository itself!

It may seem like a cool idea but will come back and bite you in some way. Do as K8s, have a format test in CI that fails.

@uablrek
Copy link
Contributor

uablrek commented Oct 15, 2022

For instance;
an update trigs an event -> the event updates the repo -> an update trigs an event -> ...

If you have more than one event that updates the code this is likely, and will ruin your day.

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 8, 2023
@knabben
Copy link
Contributor

knabben commented Apr 4, 2023

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 4, 2023
@gitvinit
Copy link
Contributor

/assign

@abhishek44sharma
Copy link

@gitvinit are you working on this?

@gitvinit
Copy link
Contributor

This should be done with PR: #485

@liangyuanpeng
Copy link

So this issue should be closed.

@gitvinit
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@gitvinit: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

10 participants