-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
keybinder packaging #15
Comments
Well, there are two tarballs there: the one you describe is labeled by GitHub as "Source code (tar.gz)". Right above that, there's also
All in all, I agree with you that the "Releases" page is more confusing than it needs to be. Obviously, some cleanup needs to be done. Would you care enough to prepare a patch? :) |
I do not know how to do packaging on github. I would name the gtk3 package keybinder3-0.3.2.tar.gz or perhaps keybinder-1.0.0.tar.gz. The change to gtk3 seems to be significant enough to warrant a major version number increment. Are you going to support both versions? If so, then the 1st option seems appropriate. By the way, since BLFS supports over 1000 packages, it is welcome if download via wget is supported as well as via browser. What we use now is: https://github.com/kupferlauncher/keybinder/releases/download/v0.3.1/keybinder-0.3.1.tar.gz |
That URL is totally fine even for a book. GitHub doesn't try to make downloads difficult, Next, the "support both versions" question is not really for me to answer... @kupferlauncher can you please promote me to a contributor or better? I've been maintaining Guake for some years, and using/watching If I were to answer indeed: I'd ditch the gtk2 support from master (meaning: just archive it in a Finally @bdubbs, since you mention BLFS, I believe this indicates you're well versed in GNU Autoconf/Automake?.. "GitHub packaging" is really really simple: it just takes a zip archive of everything in master, and posts that as "Source code (zip)", plus any additional artifacts that the releaser uploads manually. OTOH, I know that autoconf generates separate targets to explicitly build a distribution/release tarball. Would it be possible to simplify this process? Ideally, just a plain tar.gz of all VCS-tracked sources (at a tagged revision) should be good enough as a release tarball. |
@ulidtko, I do know how to use wget from github, although it is not always obvious. The packaging of keybinder-0.3.1.tar.gz is fine. The packaging of keybinder-keybinder-3.0-v0.3.2.tar.gz is cumbersome. I'll note that many packages on github specifically place a version specific url on their release page. For example https://github.com/apple/cups/releases/ |
I was about to file a separate issue but just discovered this here. I agree with bdubbs. This is not necessarily unique to linux from scratch but I noticed my ruby scripts having
If you look at slackware: http://www.slackware.com/changelog/current.php?cpu=x86_64 to jump to: l/keybinder-0.3.1-x86_64-2.txz: Removed. So Patrick named this "keybinder3-3.0" which adds to the confusion, So I think I am not the only one confused; neither Patrick, nor bdubbs. From the thread I read that the 3.0 indicates support for gtk+3. Now first - I think it is bad to indicate support for gtk+3 like this HOWEVER had, what I find REALLY bad is then the ".0" part Keep in mind that gtk+ is at this URL right now: http://ftp.gnome.org/pub/gnome/sources/gtk+/3.24/gtk+-3.24.20.tar.xz If you look, the name is "gtk+" and the version is "3.24.20". This is Perhaps renaming the project would be cumbersome too, so I may Personally I think the naming schemes such as for gtk+ are very
This is a weird comment because a) most .so files are versioned anyway,
Not really. Github has not learned yet that simplicity is key: so an archive called: should expand to PRECISELY that name as is, all the time. Instead Guys, if you don't want to believe me (my fake-package manager Simplicity is great! Let's not bloat up the names to infinity here. |
Not sure if this helps, but there's a common trick to correct whatever naming blunders: Keep in mind that this repo hasn't seen its maintainer in ~ 3 years. @kupferlauncher ping! |
I know this is very late and the last release was a year ago, but when I download the tarball for the latest release from github, I get:
keybinder-keybinder-3.0-v0.3.2.tar.gz
when I think is should be simply:
keybinder-0.3.2.tar.gz
The tarball also extracts to the directory keybinder-keybinder-3.0-v0.3.2 and this is confusing.
The text was updated successfully, but these errors were encountered: