Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change and save Chunk Settings #12794

Closed
5 tasks done
hexxyan opened this issue Jan 16, 2025 · 2 comments · Fixed by #12833
Closed
5 tasks done

change and save Chunk Settings #12794

hexxyan opened this issue Jan 16, 2025 · 2 comments · Fixed by #12833
Labels
🐞 bug Something isn't working

Comments

@hexxyan
Copy link

hexxyan commented Jan 16, 2025

Self Checks

  • This is only for bug report, if you would like to ask a question, please head to Discussions.
  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

Dify version

15.1

Cloud or Self Hosted

Self Hosted (Docker)

Steps to reproduce

图片
图片

I dont know how to change and save Chunk Settings if file uploaded

✔️ Expected Behavior

can change Chunk Settings if uploaded

❌ Actual Behavior

can’t change Chunk Settings if uploaded

Copy link

dosubot bot commented Jan 16, 2025

@hexxyan Hello! I'm here to help you with any bugs, questions, or contributions you have. Let's tackle this issue together!

In Dify, once a chunk mode is selected and the knowledge base is created, it cannot be changed later. This is a limitation of the Chunk Settings feature. Any new documents added will follow the same chunking strategy that was initially set [1].

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@dosubot dosubot bot added the 🐞 bug Something isn't working label Jan 16, 2025
@kurokobo
Copy link
Contributor

@douxc @WTW0313
Hi,

I've faced the same issue; on Chunk Settings page for the existing documents, we cannot update Delimiter or Maximum chunk length as the Save & Process button has been disabled.

Image

This is due to the condition !datasetId:

{!datasetId && <Button loading={isCreating} variant='primary' onClick={createHandle}>{t('datasetCreation.stepTwo.save')}</Button>}

This line is updated by your commit: 9214cc8#diff-9a598b3479094455005fb30da13e5a1065aa5a3f8a3b007ccec7b38993dad7dfL1013 in #12206

In the current implementation, StepTwo can never be called without datasetId, so there is no chance for the Save button to be displayed on the Chunk Settings page for existing documents.
Is there any specific reason why this button is disabled on the Settings page? Is this intended or bug?

Thanks in advance!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants