Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support NGINX_ENABLED Environment Variable #12905

Open
4 of 5 tasks
comfuture opened this issue Jan 21, 2025 · 0 comments
Open
4 of 5 tasks

Support NGINX_ENABLED Environment Variable #12905

comfuture opened this issue Jan 21, 2025 · 0 comments
Labels
💪 enhancement New feature or request

Comments

@comfuture
Copy link
Contributor

Self Checks

  • I have searched for existing issues search for existing issues, including closed ones.
  • I confirm that I am using English to submit this report (我已阅读并同意 Language Policy).
  • [FOR CHINESE USERS] 请务必使用英文提交 Issue,否则会被关闭。谢谢!:)
  • Please do not modify this template :) and fill in all the required fields.

1. Is this request related to a challenge you're experiencing? Tell me about your story.

When using Docker to run Dify, an Nginx container is launched. This container provides a reverse proxy for API and web, and, depending on the options, it supports HTTPS and certbot certificate renewal, making it convenient.
However, by default, EXPOSE_NGINX_PORT and EXPOSE_NGINX_SSL_PORT are set to 80 and 443 respectively, and the ports mapping of the Nginx service is mapped to ports 80 and 443 of the host machine, which can lead to conflicts with the host machine's already running Nginx.

If you want to set up a direct Nginx reverse proxy along with other services running on the host machine, changing the EXPOSE ports to arbitrary values that are not in use will solve the issue, but the unused Nginx Docker container will still be running.

Proposal

Introduce an option: NGINX_ENABLED: ${NGINX_ENABLED:-false}
and provide a choice to not use Nginx.

I believe this change will give more flexibility to the deployment environment using Docker.

2. Additional context or comments

No response

3. Can you help us with this feature?

  • I am interested in contributing to this feature.
@dosubot dosubot bot added the 💪 enhancement New feature or request label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant