Skip to content

Problems (type definitions?) in default vue-starter-kit #55573

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mark1502 opened this issue Apr 27, 2025 · 3 comments
Closed

Problems (type definitions?) in default vue-starter-kit #55573

mark1502 opened this issue Apr 27, 2025 · 3 comments

Comments

@mark1502
Copy link

Laravel Version

12.10.2

PHP Version

8.3.14

Database Driver & Version

No response

Description

I wanted to change the delay on the progress indicator, so I edited the /resources/js/app.ts file. When I opened the file, vscode indicated 2 problems/errors in the file. I had not made any changes to the file.

Here is a screenshot of the identified problems:
zoomed in view of identified problems on the page

Here's a screenshot of the full screen:
Full screen view of identified problems on the page

Steps To Reproduce

Create a new application using the vue-starter-kit. Open the /resources/js/app.ts file in vscode. (I also have ESLint 3.0.10 installed in vscode.)

When you open the page, the problems should be flagged at the bottom of the page.

@crynobone
Copy link
Member

Hey there, thanks for reporting this issue.

If you notice improper DocBlock, PHPStan, or IDE warnings while using Laravel, do not create a GitHub issue. Instead, please submit a pull request to fix the problem. Also see our contribution guide.

Thanks!

@mark1502
Copy link
Author

Thanks for your response! I initially tried submitting the issue to the vue-starter-kit repository, but there is no issues tab there. So I tried to create a pull request, but had no idea how to address this issue and didn't have any code to submit.

In the future, if I were to submit a pull request in such a situation, what code should I submit with the request? Please forgive me if this is a stupid question. I've never done a pull request before and I'm woefully ignorant of git and github in general.

Thanks again!

@mark1502
Copy link
Author

Because you haven't yet responded, I figured I'd look to see what changes were made to address this issues raised. But I could not find any change made to the relevant page.

You closed this issue, but what changes were made to address the issues raised?

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants