Merge from mainline.

tlattner · tlattner · commit 53e6bb75cf67 · 2008-01-21T20:43:02.000Z
Make sure the caller doesn't use freed memory. Fixes PR1935. git-svn-id: https://llvm.org/svn/llvm-project/llvm/branches/release_22@46213 91177308-0d34-0410-b5e6-96231b3b80d8
diff --git a/lib/Transforms/Scalar/CodeGenPrepare.cpp b/lib/Transforms/Scalar/CodeGenPrepare.cpp
@@ -401,8 +401,10 @@ static bool OptimizeNoopCopyExpression(CastInst *CI, const TargetLowering &TLI){
   }
   
   // If we removed all uses, nuke the cast.
-  if (CI->use_empty())
+  if (CI->use_empty()) {
     CI->eraseFromParent();
+    MadeChange = true;
+  }
   
   return MadeChange;
 }

Original file line number	Diff line number	Diff line change
`@@ -401,8 +401,10 @@ static bool OptimizeNoopCopyExpression(CastInst *CI, const TargetLowering &TLI){`
`401`	`401`	`}`
`402`	`402`
`403`	`403`	`// If we removed all uses, nuke the cast.`
`404`		`- if (CI->use_empty())`
	`404`	`+ if (CI->use_empty()) {`
`405`	`405`	`CI->eraseFromParent();`
	`406`	`+ MadeChange = true;`
	`407`	`+ }`
`406`	`408`
`407`	`409`	`return MadeChange;`
`408`	`410`	`}`