Skip to content

Commit 0b6a1e0

Browse files
authored
Merge pull request #15 from lazycoderio/codacy
cleaning up for codacy
2 parents b1b6463 + 1469d90 commit 0b6a1e0

File tree

8 files changed

+35
-86
lines changed

8 files changed

+35
-86
lines changed

mac-only.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
</run>
99
</groups>
1010
<classes>
11-
<class name="LocalBrowsers.Chrome"/>
12-
<class name="LocalBrowsers.Edge"/>
13-
<class name="LocalBrowsers.Firefox"/>
14-
<class name="LocalBrowsers.PhantomJS"/>
15-
<class name="LocalBrowsers.Safari"/>
11+
<class name="localbrowsers.Chrome"/>
12+
<class name="localbrowsers.Edge"/>
13+
<class name="localbrowsers.Firefox"/>
14+
<class name="localbrowsers.PhantomJS"/>
15+
<class name="localbrowsers.Safari"/>
1616
</classes>
1717
</test> <!-- javajenkins -->
1818
</suite> <!-- Custom suite -->

src/test/java/LocalBrowsersSampleTest.java

Lines changed: 0 additions & 59 deletions
This file was deleted.

src/test/java/LocalBrowsers/Chrome.java renamed to src/test/java/localbrowsers/Chrome.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
1-
package LocalBrowsers;
1+
package localbrowsers;
22

33
import org.openqa.selenium.WebDriver;
44
import org.openqa.selenium.chrome.ChromeDriver;
55
import org.openqa.selenium.chrome.ChromeOptions;
66
import org.openqa.selenium.remote.DesiredCapabilities;
77
import org.testng.Assert;
8-
import org.testng.annotations.*;
8+
import org.testng.annotations.AfterTest;
9+
import org.testng.annotations.BeforeTest;
10+
import org.testng.annotations.Test;
911

1012
/**
1113
* Created by andrew on 12/3/16.
1214
*/
1315
@Test(groups = {"mac", "windows"})
1416
public class Chrome {
15-
WebDriver driver;
17+
private WebDriver driver;
1618

1719
@BeforeTest
1820
public void chromeSetup(){

src/test/java/LocalBrowsers/Edge.java renamed to src/test/java/localbrowsers/Edge.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,20 @@
1-
package LocalBrowsers;
1+
package localbrowsers;
22

33
import org.openqa.selenium.WebDriver;
4-
import org.openqa.selenium.chrome.ChromeDriver;
54
import org.openqa.selenium.chrome.ChromeOptions;
65
import org.openqa.selenium.edge.EdgeDriver;
76
import org.openqa.selenium.edge.EdgeOptions;
87
import org.openqa.selenium.remote.DesiredCapabilities;
98
import org.testng.Assert;
10-
import org.testng.annotations.*;
9+
import org.testng.annotations.AfterTest;
10+
import org.testng.annotations.BeforeClass;
11+
import org.testng.annotations.Test;
1112

1213
/**
1314
* Created by andrew on 12/3/16.
1415
*/
1516
public class Edge {
16-
WebDriver driver;
17+
private WebDriver driver;
1718

1819
@BeforeClass
1920
public void edgeSetup(){

src/test/java/LocalBrowsers/Firefox.java renamed to src/test/java/localbrowsers/Firefox.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
1-
package LocalBrowsers;
1+
package localbrowsers;
22

33
import org.openqa.selenium.WebDriver;
44
import org.openqa.selenium.firefox.FirefoxBinary;
55
import org.openqa.selenium.firefox.FirefoxDriver;
66
import org.openqa.selenium.firefox.FirefoxProfile;
77
import org.openqa.selenium.remote.DesiredCapabilities;
88
import org.testng.Assert;
9-
import org.testng.annotations.*;
9+
import org.testng.annotations.AfterTest;
10+
import org.testng.annotations.BeforeTest;
11+
import org.testng.annotations.Test;
1012

1113
import java.io.File;
1214

@@ -15,7 +17,7 @@
1517
*/
1618
@Test(groups = {"mac", "windows"})
1719
public class Firefox {
18-
WebDriver driver;
20+
private WebDriver driver;
1921

2022
@BeforeTest
2123
public void firefoxSetup() {

src/test/java/LocalBrowsers/PhantomJS.java renamed to src/test/java/localbrowsers/PhantomJS.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
1-
package LocalBrowsers;
1+
package localbrowsers;
22

33
import org.openqa.selenium.WebDriver;
44
import org.openqa.selenium.phantomjs.PhantomJSDriver;
5-
import org.openqa.selenium.remote.DesiredCapabilities;
65
import org.testng.Assert;
7-
import org.testng.annotations.*;
6+
import org.testng.annotations.AfterTest;
7+
import org.testng.annotations.BeforeTest;
8+
import org.testng.annotations.Test;
89

910
/**
1011
* Created by andrew on 12/3/16.
1112
*/
1213
@Test(groups = {"mac", "windows"})
1314
public class PhantomJS {
14-
WebDriver driver;
15+
private WebDriver driver;
1516

1617
@BeforeTest
1718
public void phantomJSSetup(){

src/test/java/LocalBrowsers/Safari.java renamed to src/test/java/localbrowsers/Safari.java

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,20 @@
1-
package LocalBrowsers;
1+
package localbrowsers;
22

33
import org.openqa.selenium.WebDriver;
44
import org.openqa.selenium.remote.DesiredCapabilities;
55
import org.openqa.selenium.safari.SafariDriver;
66
import org.openqa.selenium.safari.SafariOptions;
77
import org.testng.Assert;
8-
import org.testng.annotations.*;
8+
import org.testng.annotations.AfterTest;
9+
import org.testng.annotations.BeforeTest;
10+
import org.testng.annotations.Test;
911

1012
/**
1113
* Created by andrew on 12/3/16.
1214
*/
1315
@Test//(groups = {"mac"})
1416
public class Safari {
15-
WebDriver driver;
17+
private WebDriver driver;
1618

1719
@BeforeTest
1820
public void safariSetup(){

windows-only.xml

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@
88
</run>
99
</groups>
1010
<classes>
11-
<class name="LocalBrowsers.Chrome"/>
12-
<class name="LocalBrowsers.Edge"/>
13-
<class name="LocalBrowsers.Firefox"/>
14-
<class name="LocalBrowsers.PhantomJS"/>
15-
<class name="LocalBrowsers.Safari"/>
11+
<class name="localbrowsers.Chrome"/>
12+
<class name="localbrowsers.Edge"/>
13+
<class name="localbrowsers.Firefox"/>
14+
<class name="localbrowsers.PhantomJS"/>
15+
<class name="localbrowsers.Safari"/>
1616
</classes>
1717
</test> <!-- javajenkins -->
1818
</suite> <!-- Custom suite -->

0 commit comments

Comments
 (0)