Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: network settings #949

Open
Technophant opened this issue Jan 15, 2018 · 8 comments
Open

Feature request: network settings #949

Technophant opened this issue Jan 15, 2018 · 8 comments
Labels
hacktoberfest Welcome to Hacktoberfest help wanted icebox Long-term storage needs: exploration Solution unclear, needs research

Comments

@Technophant
Copy link

Technophant commented Jan 15, 2018

In addition to having a visual network status indicator (#603), there needs to be network settings similar to what is found in other peer2peer clients.

Some things that should be included:
connection_status: code & message
blocks_behind, if zero then return up-to-date
startup_status
toggle use_pnp
set peer_port
simple port status check (open or closed)
set random port option
set proxy port
be able to set upload and download bandwidth limits (upload is more important)
bandwidth test and auto-set upload bandwidth perhpas
be able to change reflector server

@liamcardenas liamcardenas added the needs: exploration Solution unclear, needs research label Jan 16, 2018
@tzarebczan
Copy link
Contributor

@Technophant thanks for creating this issue! A few of the items you mentioned already have separate issues open on the daemon side - lbryio/lbry-sdk#1002 (proxy), lbryio/lbry-sdk#798 (BW limits), lbryio/lbry-sdk#934 (port check)

Also, I'm not sure we want to expose all of these settings to the users, at least not without going into some "advanced configuration" menu - i.e a typical (or even advanced user) would not know what a reflector server is or what options to set.

Feel free to explore a bit more and then edit your original issue as needed.

Thanks again for the contribution, please see https://lbry.io/faq/tips

@kauffj
Copy link
Member

kauffj commented Jan 17, 2018

@tzarebczan I think it makes sense to add a simple UI for settings like peer_port and use_upnp, which already exist via settings_set.

@Technophant let me know if you're interested in working on any of these ;) But thanks for opening either way!

@Technophant
Copy link
Author

Technophant commented Jan 30, 2018

I'm busy with other things, but yes those two options would be easy to add to the UI and would pretty much take care of my concerns except for the upload bandwidth it takes up. I have a decent cable connection, however I needed to close it because it was causing me issues. 1 Mbit up and down with daemon running but nothing requested.

@alyssaoc alyssaoc added the icebox Long-term storage label Oct 9, 2018
@neb-b neb-b added hacktoberfest Welcome to Hacktoberfest help wanted labels Sep 30, 2019
@ahmedkrmn
Copy link

Can I work on this?

@tzarebczan
Copy link
Contributor

@ahmedkrmn , it's all yours! Some of the settings do require a full restart of the app+sdk, so we would have to make that option available as part of this effort.

The ones I think we should focus on are:

use_upnp
peer_port
udp_port

@ahmedkrmn
Copy link

ahmedkrmn commented Oct 11, 2019

Hey @tzarebczan, I can't find the function definition of Lbry.settings_set() in either lbry-desktop or lbry-redux.

@kauffj
Copy link
Member

kauffj commented Oct 14, 2019

@ahmedkrmn all Lbry.xxx() API calls are simple pass-throughs to this API: https://lbry.tech/api/sdk

@trymeouteh
Copy link

trymeouteh commented Aug 2, 2022

Here are some suggestions also

#7657

#7658

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Welcome to Hacktoberfest help wanted icebox Long-term storage needs: exploration Solution unclear, needs research
Projects
None yet
Development

No branches or pull requests

8 participants