Skip to content

Commit 534e4b7

Browse files
caoglishblakeembrey
authored andcommitted
Add more php unit test cases and fix php solution (blakeembrey#177)
1 parent 8eaf1f1 commit 534e4b7

File tree

5 files changed

+44
-19
lines changed

5 files changed

+44
-19
lines changed

solutions/php/reverse-words-in-string.php

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,5 @@
22

33
function reverseWordsInStrings($string)
44
{
5-
return implode(array_reverse(preg_split('/\s+/', $string)), ' ');
5+
return trim(implode(array_reverse(preg_split('/\s+/', $string)), ' '));
66
}
7-
8-
?>
Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,10 @@
11
<?php
22

3-
function SumOfIntegers ($integerArray) {
4-
$sum = 0;
5-
foreach ($integerArray as $valor) {
6-
$sum += $valor;
7-
}
8-
return $sum + count($integerArray);
3+
function SumOfArrayPlusOne($integerArray)
4+
{
5+
$sum = 0;
6+
foreach ($integerArray as $valor) {
7+
$sum += $valor;
8+
}
9+
return $sum + count($integerArray);
910
}
10-
11-
?>

tests/php/factorialTest.php

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,16 @@
11
<?php
22
use PHPUnit\Framework\TestCase;
33

4-
require_once 'solutions/php/factorial.php';
4+
require_once 'solutions/php/factorial.php';
55

6-
class StackTest extends TestCase
6+
class FactorialTest extends TestCase
77
{
88
public function test_factorial()
99
{
10-
$this->assertEquals(1,factorial(1) );
11-
$this->assertEquals(2,factorial(2) );
12-
$this->assertEquals(6,factorial(3) );
13-
$this->assertEquals(120,factorial(5) );
14-
$this->assertEquals(2432902008176640000,factorial(20) );
10+
$this->assertEquals(1, factorial(1));
11+
$this->assertEquals(2, factorial(2));
12+
$this->assertEquals(6, factorial(3));
13+
$this->assertEquals(120, factorial(5));
14+
$this->assertEquals(2432902008176640000, factorial(20));
1515
}
1616
}
17-
?>
Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
<?php
2+
use PHPUnit\Framework\TestCase;
3+
4+
require_once 'solutions/php/reverse-words-in-string.php';
5+
6+
class reverseWordsInStringsTest extends TestCase
7+
{
8+
public function test_reverseWordsInStrings()
9+
{
10+
$this->assertEquals("awesome! are Interviews", reverseWordsInStrings("Interviews are awesome!"));
11+
$this->assertEquals("degree CS", reverseWordsInStrings(" CS degree"));
12+
$this->assertEquals("degree CS", reverseWordsInStrings("CS degree"));
13+
$this->assertEquals("degree CS", reverseWordsInStrings("CS degree "));
14+
$this->assertEquals("degree CS", reverseWordsInStrings(" CS degree "));
15+
}
16+
}
Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
<?php
2+
use PHPUnit\Framework\TestCase;
3+
4+
require_once 'solutions/php/sum-of-array-plus-one.php';
5+
6+
class sumOfArrayPlusOneTest extends TestCase
7+
{
8+
public function test_SumOfArrayPlusOne()
9+
{
10+
$this->assertEquals(14, SumOfArrayPlusOne([1, 2, 3, 4]));
11+
12+
}
13+
}

0 commit comments

Comments
 (0)