Skip to content
This repository has been archived by the owner on May 30, 2021. It is now read-only.

Please add samples #3

Open
rajjaiswalsaumya opened this issue Sep 16, 2016 · 12 comments
Open

Please add samples #3

rajjaiswalsaumya opened this issue Sep 16, 2016 · 12 comments
Assignees

Comments

@rajjaiswalsaumya
Copy link

rajjaiswalsaumya commented Sep 16, 2016

issue
Please provide samples on how to use this library. It is pretty great solution and I think this should be an active community.

Suggestion ->
please change your project structure as ->

swing-material
         swing-material
         swing-material-samples

This way anyone will be able to use it by looking into samples and also you will be able to run samples as live tests upon build.

My issue, I am adding materialpasswordfield but the hint label is painting below box line. Help!!

@leMaik
Copy link
Owner

leMaik commented Sep 16, 2016

I will add samples and better documentation soon, I just didn't think that anyone would have a use case for this project. Meanwhile, you may want to take a look at the Craften Launcher it uses swing-material.

I think that you have to specify the height of the password field. The project mentioned above uses a password field.

@leMaik leMaik closed this as completed Sep 16, 2016
@leMaik leMaik reopened this Sep 16, 2016
@leMaik leMaik self-assigned this Sep 16, 2016
@rajjaiswalsaumya
Copy link
Author

I can see you have not acknowledged layout managers and you have set all bounds manually which wont be a good idea in case of differing resolution screen. Can you just provide me a time so that we could discuss about it ?

@rajjaiswalsaumya
Copy link
Author

Btw I have set dimensions of the password field but I m using flowlayout for the panel. I think with that they are not compatible.

@leMaik
Copy link
Owner

leMaik commented Sep 16, 2016

@rajjaiswalsaumya Indeed, I set all bounds individually, but it seems to work fine on different screens. I don't know how this could be used with FlowLayout, but I'm sure that it should be possible by specifying the defaultSize of the Material components.

@DragShot
Copy link
Contributor

DragShot commented May 12, 2017

Well, I understand uses of this library are sort of few at the moment, as the suite of components at our disposition is small and in certain aspects incomplete; but at least let's appreciate the shadows, elevation handling and ripples, as they are certainly very well done. One or two optimizations could be done though, my old piece of PC could barely deal with the continuous shadow processing plus the rest of animations.

I'm trying to make an use out of it because I was looking for something like this yesterday for a small, sort of e-book reader. I'll try to fill in some blanks and tweak one or two things while I'm on it, and if things go fine then I'll fork this in order to send a pull request with the changes made.

swing_material_001.png

@leMaik
Copy link
Owner

leMaik commented May 12, 2017

@DragShot That would be great! 👍
Unfortunately, I don't have much time right now to document this library, but I'll come back to this when I have some more spare time. I know it would be much easier to use this if there were a few examples. Well, at least, we have Javadoc everywhere.

Edit: To be honest, this library contains exactly the set of components that I needed in our Minecraft launcher. I don't use this library for other projects and nobody has requested more components yet. 😅

@DragShot
Copy link
Contributor

I've forked your project and added some of the changes I've made on my end so far. There are inline comments starting with "DS-addons:" explaining the purpose of each modification. Also, some docs have been added.

You can take a look and tell me what you think.

@leMaik
Copy link
Owner

leMaik commented May 16, 2017

@DragShot Wow, that are some great additions! I'd really appreciate a PR from you, just remove the inline comments (you can see the changes in the commit diff). 👍

@DragShot
Copy link
Contributor

@leMaik Yes, I am aware of the diff, those comments are only for preview and will be removed before the PR is sent. Right now I'm working in a sort of Frame decorator (title bar, control buttons, window resizing) for the MaterialWindow. I'll commit the changes once it is done.

@leMaik
Copy link
Owner

leMaik commented May 16, 2017

@DragShot It would be easier for me to review the changes and apply them one by one if you'd create a full request for every change / new feature. 😉

@DragShot
Copy link
Contributor

Alright, I've cleaned the files and posted the first PE. You should be able to see it now, @leMaik.

@leMaik
Copy link
Owner

leMaik commented May 24, 2017

@pedrohidalgo Ping 😉

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants