Skip to content

Commit 5c41802

Browse files
oranagraantirez
authored andcommitted
fix unstable replication test
this test which has coverage for varoius flows of diskless master was failing randomly from time to time. the failure was: [err]: diskless all replicas drop during rdb pipe in tests/integration/replication.tcl log message of '*Diskless rdb transfer, last replica dropped, killing fork child*' not found what seemed to have happened is that the master didn't detect that all replicas dropped by the time the replication ended, it thought that one replica is still connected. now the test takes a few seconds longer but it seems stable.
1 parent a23cdbb commit 5c41802

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

tests/integration/replication.tcl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -513,9 +513,9 @@ start_server {tags {"repl"}} {
513513
set master_port [srv 0 port]
514514
set master_pid [srv 0 pid]
515515
# put enough data in the db that the rdb file will be bigger than the socket buffers
516-
# and since we'll have key-load-delay of 100, 10000 keys will take at least 1 second
516+
# and since we'll have key-load-delay of 100, 20000 keys will take at least 2 seconds
517517
# we also need the replica to process requests during transfer (which it does only once in 2mb)
518-
$master debug populate 10000 test 10000
518+
$master debug populate 20000 test 10000
519519
$master config set rdbcompression no
520520
# If running on Linux, we also measure utime/stime to detect possible I/O handling issues
521521
set os [catch {exec unamee}]

0 commit comments

Comments
 (0)