add test and changelog

Author: erohmensing

changelog/5361.bugfix.rst

@@ -0,0 +1 @@
+Fixed bug where starting or ending a response with ``\n\n`` led to one of the responses returned being empty.

docs/conf.py

@@ -139,7 +139,7 @@
     "fixed_sidebar": True,
     "product": "Rasa",
     "base_url": "https://rasa.com/docs/rasa/",
-    "canonical_url": "https://rasa.com/docs/rasa/"
+    "canonical_url": "https://rasa.com/docs/rasa/",
 }
 # html_theme_options = {}
 

tests/core/test_channels.py

@@ -57,6 +57,7 @@ def fake_send_message(*args, **kwargs):
 
 async def test_send_response(default_channel, default_tracker):
     text_only_message = {"text": "hey"}
+    multiline_text_message = {"text": "This message should come first:  \n\nThis is message two  \nThis as well\n\n"}
     image_only_message = {"image": "https://i.imgur.com/nGF1K8f.jpg"}
     text_and_image_message = {
         "text": "look at this",
@@ -68,32 +69,37 @@ async def test_send_response(default_channel, default_tracker):
     }
 
     await default_channel.send_response(default_tracker.sender_id, text_only_message)
+    await default_channel.send_response(default_tracker.sender_id, multiline_text_message)
     await default_channel.send_response(default_tracker.sender_id, image_only_message)
     await default_channel.send_response(
         default_tracker.sender_id, text_and_image_message
     )
     await default_channel.send_response(default_tracker.sender_id, custom_json_message)
     collected = default_channel.messages
 
-    assert len(collected) == 6
+    assert len(collected) == 8
 
     # text only message
     assert collected[0] == {"recipient_id": "my-sender", "text": "hey"}
 
+    # multiline text message, should split on '\n\n'
+    assert collected[1] == {"recipient_id": "my-sender", "text": "This message should come first:  "}
+    assert collected[2] == {"recipient_id": "my-sender", "text": "This is message two  \nThis as well"}
+
     # image only message
-    assert collected[1] == {
+    assert collected[3] == {
         "recipient_id": "my-sender",
         "image": "https://i.imgur.com/nGF1K8f.jpg",
     }
 
     # text & image combined - will result in two messages
-    assert collected[2] == {"recipient_id": "my-sender", "text": "look at this"}
-    assert collected[3] == {
+    assert collected[4] == {"recipient_id": "my-sender", "text": "look at this"}
+    assert collected[5] == {
         "recipient_id": "my-sender",
         "image": "https://i.imgur.com/T5xVo.jpg",
     }
-    assert collected[4] == {"recipient_id": "my-sender", "text": "look at this"}
-    assert collected[5] == {
+    assert collected[6] == {"recipient_id": "my-sender", "text": "look at this"}
+    assert collected[7] == {
         "recipient_id": "my-sender",
         "custom": {"some_random_arg": "value", "another_arg": "value2"},
     }