Skip to content

Commit 807d9b0

Browse files
authored
Merge pull request RasaHQ#5366 from DomAmato/bugfix/fallback
Fix bug where Fallback Policy always falls back when fallback action is action listen
2 parents 3a49f2a + 71be250 commit 807d9b0

File tree

2 files changed

+11
-1
lines changed

2 files changed

+11
-1
lines changed

changelog/5356.bugfix.rst

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
Fixed bug where ``FallbackPolicy`` would always fall back if the fallback action is
2+
``action_listen``.

rasa/core/policies/fallback.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,15 @@ def predict_action_probabilities(
144144

145145
nlu_data = tracker.latest_message.parse_data
146146

147-
if tracker.latest_action_name == self.fallback_action_name:
147+
if (
148+
tracker.latest_action_name == self.fallback_action_name
149+
and tracker.latest_action_name != ACTION_LISTEN_NAME
150+
):
151+
logger.debug(
152+
"Predicted 'action_listen' after fallback action '{}'".format(
153+
self.fallback_action_name
154+
)
155+
)
148156
result = self._default_predictions(domain)
149157
idx = domain.index_for_action(ACTION_LISTEN_NAME)
150158
result[idx] = 1.0

0 commit comments

Comments
 (0)