Merge pull request RasaHQ#5309 from RasaHQ/additional-events-fix-2

ricwo · web-flow · commit c610325730a5 · 2020-02-24T19:26:38.000+01:00
Do not save tracker during session update
diff --git a/changelog/5068.bugfix.rst b/changelog/5068.bugfix.rst
@@ -0,0 +1,7 @@
+Tracker stores supporting conversation sessions (``SQLTrackerStore`` and
+``MongoTrackerStore``) do not save the tracker state to database immediately after
+starting a new conversation session. This leads to the number of events being saved
+in addition to the already-existing ones to be calculated correctly.
+
+This fixes ``action_listen`` events being saved twice at the beginning of
+conversation sessions.
diff --git a/rasa/core/processor.py b/rasa/core/processor.py
@@ -175,8 +175,6 @@ async def _update_tracker_session(
                 nlg=self.nlg,
             )
 
-            self.tracker_store.save(tracker)
-
     async def get_tracker_with_session_start(
         self, sender_id: Text, output_channel: Optional[OutputChannel] = None,
     ) -> Optional[DialogueStateTracker]:

Original file line number	Diff line number	Diff line change
`@@ -175,8 +175,6 @@ async def _update_tracker_session(`
`175`	`175`	`nlg=self.nlg,`
`176`	`176`	`)`
`177`	`177`
`178`		`- self.tracker_store.save(tracker)`
`179`		`-`
`180`	`178`	`async def get_tracker_with_session_start(`
`181`	`179`	`self, sender_id: Text, output_channel: Optional[OutputChannel] = None,`
`182`	`180`	`) -> Optional[DialogueStateTracker]:`